Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy-loaded rooms to historical cannot be forgotten #9168

Closed
turt2live opened this issue Mar 14, 2019 · 10 comments
Closed

Lazy-loaded rooms to historical cannot be forgotten #9168

turt2live opened this issue Mar 14, 2019 · 10 comments

Comments

@turt2live
Copy link
Member

No description provided.

@aaronraimist
Copy link
Collaborator

Keywords: forget room option missing from historical section of room list

@anoadragon453
Copy link
Member

anoadragon453 commented Mar 14, 2019

I'm confused. So a room that has lazy-loading enabled doesn't disappear when you click Forget on it?

@aaronraimist
Copy link
Collaborator

aaronraimist commented Mar 14, 2019

No. It doesn’t have a forget button at all. --(https://matrix.to/#/!QtykxKocfZaZOUrTwp%3Amatrix.org/%2415525377971071233GYPFN%3Amatrix.org)-- EDIT: this event has been redacted -- @lampholder

@turt2live
Copy link
Member Author

It's not related to the lazy loading you're thinking of. When you open the section it lazily loads rooms to shove in there, which can take a while. Once it succeeds, the rooms can't be forgotten.

@lampholder
Copy link
Member

I'm still too confused to triage this I'm afraid. Can we have some repro steps and screenshots?

@lampholder lampholder added the X-Needs-Info This issue is blocked awaiting information from the reporter label Mar 18, 2019
@turt2live
Copy link
Member Author

turt2live commented Mar 18, 2019

  1. Leave a room so the historical section shows up
  2. Click on said historical section to expand it
  3. Wait infinite amounts of time for the hidden spinner to stop spinning (for the request to complete)
    • You may have to close and re-open the section until the request completes. It is not retried.
  4. Rooms that pop in are not forgettable

nb: step 3 is a different bug, which is somewhere in the pile of "historical section sucks" bugs

@SilverWolf32
Copy link

I'm having this issue as well (on the desktop client if it matters, which it probably doesn't). In my case it was a room I clicked on and loaded, but never actually joined.

@earfolds
Copy link

I get this on my matrix.org account. If I leave a room, the historical section pops up, and lists several rooms that are not forgettable. Clearing cache and reload hides the historical section.

@robmv
Copy link

robmv commented Apr 28, 2019

Same problem here, I join or create a new room and then leave, this new room appear on the Historical section, with another private chat I leaved a week ago that has no option to leave today. @earfolds recommendation of Clearing cache worked, and from now if I repeat the process, the old room doesn't reappear.

Looks like a client caching issue

Edit: and now the historical section and previous leaved rooms reappeared after I left the screen unattended for 10 minutes without doing nothing

@t3chguy
Copy link
Member

t3chguy commented Nov 14, 2024

Historical is gone

@t3chguy t3chguy closed this as completed Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants