Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to ensure resolved modules are singleton instances #9093

Closed
jryans opened this issue Mar 8, 2019 · 1 comment
Closed

Add tests to ensure resolved modules are singleton instances #9093

jryans opened this issue Mar 8, 2019 · 1 comment
Labels
A-Developer-Experience A-Testing Testing, code coverage, etc. T-Task Tasks for the team like planning

Comments

@jryans
Copy link
Collaborator

jryans commented Mar 8, 2019

There may be cases today where require('<X>') gives different instances depending on where you are requiring from. This is generally not expected or intended for a well-functioning JS module system. (It is believed this may occur today across the high-level boundaries like Riot vs. SDKs, perhaps because we have not yet integrated them into a single build.)

We should ensure this works as expected for a consistent developer experience and add tests to ensure it stays that way going forward.

See also: matrix-org/matrix-react-sdk#2770 (comment)

@jryans jryans added T-Task Tasks for the team like planning P1 labels Mar 8, 2019
@kittykat kittykat added the A-Testing Testing, code coverage, etc. label Nov 4, 2021
@Johennes
Copy link
Contributor

Closing as this doesn't appear to have caused any practical issues since March 2019.

@Johennes Johennes closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Developer-Experience A-Testing Testing, code coverage, etc. T-Task Tasks for the team like planning
Projects
None yet
Development

No branches or pull requests

4 participants