Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Manually verify all remote sessions" does nothing #27613

Closed
richvdh opened this issue Jun 20, 2024 · 0 comments · Fixed by matrix-org/matrix-react-sdk#12706
Closed

"Manually verify all remote sessions" does nothing #27613

richvdh opened this issue Jun 20, 2024 · 0 comments · Fixed by matrix-org/matrix-react-sdk#12706
Assignees
@uhoreg
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust A-Session-Mgmt Session / device names, management UI, etc. O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression

Comments

@richvdh
Copy link
Member

richvdh commented Jun 20, 2024

At the bottom of the Security & Privacy settings page, there is this switch:

image

As far as I can tell, it does absolutely nothing. In particular, when enabled at the same time as "Never send encrypted messages to unverified sessions from this session", encrypted messages are still sent to devices which are only verified via cross-signing.

I think we never wired up this switch as part of Element-R. IMHO, we should remove it.
@richvdh richvdh added T-Defect A-Element-R Issues affecting the port of Element's crypto layer to Rust labels Jun 20, 2024
@dosubot dosubot bot added A-Session-Mgmt Session / device names, management UI, etc. O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Jun 20, 2024
@uhoreg uhoreg self-assigned this Jun 26, 2024
@uhoreg uhoreg mentioned this issue Jun 27, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@uhoreg uhoreg

Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust A-Session-Mgmt Session / device names, management UI, etc. O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove "Manually verify all remote sessions" setting
3 participants
@dbkr @uhoreg @richvdh