Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device Dehydration v2 - Device fails to rehydrate. Extra Security Key popup that will not accept a valid key. #27546

Closed
mjw3428 opened this issue Jun 11, 2024 · 2 comments
Labels
A-E2EE-Dehydration S-Critical Prevents work, causes data loss and/or has no workaround T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter Z-Labs

Comments

@mjw3428
Copy link

mjw3428 commented Jun 11, 2024

Steps to reproduce

  1. After logging in with SSO an pop for Security Key appears.

  2. Entering a valid key is considered invalid in the dialog box and the continue button is never activated.
    image

  3. Clicking the close button on this dialog box will result in the verify device dialog box appearing. Clicking verify with securtiy key here will show the same dialog box as before, but this time the same key will be accepted.
    image

This is with device dehydration set on within the Element config.

It looks to me like it is trying to access the Security Key before the session has initialised and, since this fails, the dialog box doesn't know what your Secret Key is and so it will never match.

image

As a result it looks like it never rehydrates the device on subsequent logins.

Outcome

What did you expect?

Valid Security Keys should be accepted and device rehydration should work.

What happened instead?

The error 'Invalid Security Key is shown and the continue button is disabled.

Operating system

Docker Container (Alpine?)

Browser information

Chrome 125

URL for webapp

1.11.68

Application version

Riot version: 153d0c3-react-ab6a94aa8f76-js-131e81401a04 Crypto version: Rust SDK 0.7.0 (068a0af), Vodozemac 0.6.0

Homeserver

Synapse v1.108.0

Will you send logs?

Yes

@dosubot dosubot bot added A-E2EE-Dehydration S-Critical Prevents work, causes data loss and/or has no workaround labels Jun 11, 2024
@t3chguy
Copy link
Member

t3chguy commented Jun 12, 2024

Will you send logs?
Yes

Not seeing any logs.

@t3chguy t3chguy added the X-Needs-Info This issue is blocked awaiting information from the reporter label Jun 12, 2024
@mjw3428
Copy link
Author

mjw3428 commented Jun 12, 2024

This relates to msc2697 and not the newer 3814. Closing as no longer relevant.

@mjw3428 mjw3428 closed this as completed Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE-Dehydration S-Critical Prevents work, causes data loss and/or has no workaround T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter Z-Labs
Projects
None yet
Development

No branches or pull requests

2 participants