Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Announcements block interactions in modals without being able to be closed via keyboard #27443

Closed
t3chguy opened this issue May 7, 2024 · 0 comments · Fixed by matrix-org/matrix-react-sdk#12559
Closed

Release Announcements block interactions in modals without being able to be closed via keyboard #27443

t3chguy opened this issue May 7, 2024 · 0 comments · Fixed by matrix-org/matrix-react-sdk#12559
Assignees
@florianduros
Labels
A11y A-Left-Panel Left panel or menu. These can have other names on mobile. A-Threads O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression X-Release-Blocker

Comments

@t3chguy
Copy link
Member

t3chguy commented May 7, 2024

Steps to reproduce

  1. Log into a new account such that you get the TAC release announcement
  2. Open user settings or some other large modal
  3. Observe that you cannot use Tab to reach the TAC RA to dismiss it to be able to see the content underneath it (modal)

Outcome

What did you expect?

Either the RA renders underneath or it is closeable via keyboard

What happened instead?

It renders on top but does not appear in tabstop list

Screen.Recording.2024-05-07.at.14.32.47.mov

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

1.11.66

Homeserver

No response

Will you send logs?

No
@t3chguy t3chguy added T-Defect X-Regression S-Major Severely degrades major functionality or product features, with no satisfactory workaround X-Release-Blocker A11y O-Uncommon Most users are unlikely to come across this or unexpected workflow A-Threads A-Left-Panel Left panel or menu. These can have other names on mobile. labels May 7, 2024
@florianduros florianduros self-assigned this May 7, 2024
@florianduros florianduros mentioned this issue May 28, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@florianduros florianduros

Labels
A11y A-Left-Panel Left panel or menu. These can have other names on mobile. A-Threads O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Close the release announcement when a dialog is opened matrix-org/matrix-react-sdk
2 participants
@t3chguy @florianduros