Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ElementR: Import backup progress doesn't report progress when decrypting #26856

Closed
BillCarsonFr opened this issue Jan 11, 2024 · 2 comments · Fixed by matrix-org/matrix-js-sdk#4005
Closed

ElementR: Import backup progress doesn't report progress when decrypting #26856

BillCarsonFr opened this issue Jan 11, 2024 · 2 comments · Fixed by matrix-org/matrix-js-sdk#4005
Assignees
@BillCarsonFr
Labels
A-E2EE-Key-Backup A-Element-R Issues affecting the port of Element's crypto layer to Rust O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Labs

Comments

@BillCarsonFr
Copy link
Member

Step to reproduce

  • Have an account with a "big" backup
  • Login, verify
  • Go to settings and click on Restore from backup

Expected

  • It should download the encrypted backup and report that it's fetching from server
  • When download is complete ER should report that server fetch is done and that it's decrypting/importing keys

Actual

  • After the download, the keys are beeing decrypted but the progress status is not updated until all keys have been decrypted
image

While the sdk is actually decrypting the keys:
https://github.com/matrix-org/matrix-js-sdk/blob/8df30ed068997aa74f21aa5be3c8df30f7dd07c5/src/client.ts#L3938-L3947

But progress step is still fetch

https://github.com/matrix-org/matrix-js-sdk/blob/8df30ed068997aa74f21aa5be3c8df30f7dd07c5/src/client.ts#L3923-L3927

So it's like there is no progress, and this operations can be 10s of minutes
@BillCarsonFr BillCarsonFr added A-E2EE-Key-Backup A-Element-R Issues affecting the port of Element's crypto layer to Rust labels Jan 11, 2024
@richvdh
Copy link
Member

richvdh commented Jan 11, 2024

somewhat related: element-hq/element-meta#2176

@dbkr dbkr added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Jan 11, 2024
@BillCarsonFr
Copy link
Member Author

related #23359

@BillCarsonFr BillCarsonFr mentioned this issue Jan 12, 2024
Merged
3 tasks
@BillCarsonFr BillCarsonFr self-assigned this Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BillCarsonFr BillCarsonFr

Labels
A-E2EE-Key-Backup A-Element-R Issues affecting the port of Element's crypto layer to Rust O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Labs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Decrypt and Import full backups in chunk with progress matrix-org/matrix-js-sdk
3 participants
@dbkr @richvdh @BillCarsonFr