Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled Playwright test "Should show a grey padlock for a key restored from backup" #26811

Closed
richvdh opened this issue Dec 28, 2023 · 4 comments · Fixed by matrix-org/matrix-react-sdk#12249
Assignees
Labels
T-Task Tasks for the team like planning Team: Crypto Z-Flaky-Test A test is raising false alarms

Comments

@richvdh
Copy link
Member

richvdh commented Dec 28, 2023

https://github.com/matrix-org/matrix-react-sdk/blob/develop/playwright/e2e/crypto/crypto.spec.ts#L434-L435

@t3chguy please can you not just disable tests - especially those covering the crypto stack - without at least filing issues about them?

@richvdh richvdh added Team: Crypto Z-Flaky-Test A test is raising false alarms labels Dec 28, 2023
@t3chguy
Copy link
Member

t3chguy commented Dec 29, 2023

@richvdh
Copy link
Member Author

richvdh commented Dec 29, 2023

Yes, but that was two weeks ago. If work is immediately happening on a bug then it's reasonable to skip the tracking issue, but if other priorities get in the way then we should have a tracking issue.

@t3chguy
Copy link
Member

t3chguy commented Dec 29, 2023

I suggest chasing that with the person on that project, I've been off the Playwright project for 3-4 weeks at this point.

@richvdh
Copy link
Member Author

richvdh commented Dec 29, 2023

I'm just asking that, in future, anyone who disables a test makes sure that there is a tracking issue for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning Team: Crypto Z-Flaky-Test A test is raising false alarms
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants