-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Element-R: "Migrate to rust" labs button #26678
Comments
UX for this will be a labs button that causes the session to be restarted when it is enabled. We probably need some sort of modal that indicates the state of the migration. |
This comment was marked as resolved.
This comment was marked as resolved.
Looking at the performance of this as it stands: On a test database containing 37 olm sessions and 4810 megolm sessions:
Obviously, that is dominated by the megolm session import, at 12.5s for 4810 sessions, or ~130ms for each batch of 50 sessions. The actual time for each batch is quite variable, but there are three stages:
Somewhat unexpected that deleting things from the old db is what takes the time. We could reduce it to (empirically) about 54.9ms by iterating through the store looking for rows to delete instead of using the index (which works because we know the batch will be at the "start" of the store); or we could rewrite the whole thing to store the progress made so far and delete everything on a single batch at the end. Not sure it is worthwhile though. If we need it to go faster, we can do it in the background. |
At some point we will need to start actively migrating people who are using EW sessions on legacy Crypto to Rust crypto.
We will need a migration process for this. To gain confidence in the migration, we will add some sort of "developer feature" where people can request a migration. Later, we will automate the migration.
Tasks
Unable to load session session.sessionData.keysClaimed is undefined
#26894The text was updated successfully, but these errors were encountered: