Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add uncaught exception handler to write Uncaught promise errors in Rageshakes #26639

Closed
richvdh opened this issue Nov 24, 2023 · 0 comments · Fixed by matrix-org/matrix-react-sdk#12028
Closed

Add uncaught exception handler to write Uncaught promise errors in Rageshakes #26639

richvdh opened this issue Nov 24, 2023 · 0 comments · Fixed by matrix-org/matrix-react-sdk#12028
Assignees
@uhoreg
Labels
A-Developer-Experience O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement

Comments

@richvdh
Copy link
Member

richvdh commented Nov 24, 2023 •
edited
Loading

If an asynchronous task throws an exception without it being caught, this is written to the JS console as an "uncaught error".

However, such errors are not written to the rageshake logs.

I think we should catch unhandledrejection and write something in the RS logs
@weeman1337 weeman1337 added S-Minor Impairs non-critical functionality or suitable workarounds exist A-Developer-Experience O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement labels Nov 27, 2023
@uhoreg uhoreg self-assigned this Dec 11, 2023
@uhoreg uhoreg mentioned this issue Dec 11, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@uhoreg uhoreg

Labels
A-Developer-Experience O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Log unhandled promise rejections in the rageshake
3 participants
@uhoreg @richvdh @weeman1337