Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stray semicolon on sign out confirm modal #26623

Closed
kerryarchibald opened this issue Nov 21, 2023 · 6 comments · Fixed by matrix-org/matrix-react-sdk#12069
Closed

Stray semicolon on sign out confirm modal #26623

kerryarchibald opened this issue Nov 21, 2023 · 6 comments · Fixed by matrix-org/matrix-react-sdk#12069
Labels
A-Logout Logout, sign out, etc. good first issue Good for newcomers Help Wanted Extra attention is needed S-Minor Impairs non-critical functionality or suitable workarounds exist S-Tolerable Low/no impact on users T-Defect X-Regression

Comments

@kerryarchibald
Copy link
Contributor

Steps to reproduce

  1. Have a session with encryption setup
  2. Open user menu and click sign out

Outcome

Screen.Recording.2023-11-22.at.09.47.54.mov

Expected

Loading screen for sign out confirm modal should not have a ;

Operating system

No response

Browser information

No response

URL for webapp

develop.element.io

Application version

No response

Homeserver

No response

Will you send logs?

No

@kerryarchibald kerryarchibald added T-Defect Help Wanted Extra attention is needed good first issue Good for newcomers labels Nov 21, 2023
@t3chguy
Copy link
Member

t3chguy commented Nov 21, 2023

Regressed by matrix-org/matrix-react-sdk#11645

@florianduros florianduros added A-Logout Logout, sign out, etc. S-Minor Impairs non-critical functionality or suitable workarounds exist S-Tolerable Low/no impact on users labels Nov 22, 2023
@kimhyeonju
Copy link

@kerryarchibald Is there still an issue unresolved? If so, I would like to be involved in addressing this problem. Would that be possible?

@kerryarchibald
Copy link
Contributor Author

@kimhyeonju you're welcome to open a PR to solve this issue! Check out our contributing guide for some pointers on how to get started.

@07tAnYa
Copy link

07tAnYa commented Nov 24, 2023

@kerryarchibald Can I also start taking up this issue?

@zahidhussain998
Copy link

hey i would like to work on this issue can anybody tell me is this issue is open??

@t3chguy
Copy link
Member

t3chguy commented Nov 27, 2023

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Logout Logout, sign out, etc. good first issue Good for newcomers Help Wanted Extra attention is needed S-Minor Impairs non-critical functionality or suitable workarounds exist S-Tolerable Low/no impact on users T-Defect X-Regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants