Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken Cypress test: Spaces > should render subspaces in the space panel only when expanded #26607

Closed
richvdh opened this issue Nov 19, 2023 · 2 comments · Fixed by matrix-org/matrix-react-sdk#11909
Closed

Broken Cypress test: Spaces > should render subspaces in the space panel only when expanded #26607

richvdh opened this issue Nov 19, 2023 · 2 comments · Fixed by matrix-org/matrix-react-sdk#11909
Assignees
@t3chguy
Labels
A-Developer-Experience A-Testing Testing, code coverage, etc. O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Flaky-Test A test is raising false alarms

Comments

@richvdh
Copy link
Member

richvdh commented Nov 19, 2023 

cypress/e2e/spaces/spaces.spec.ts:
...
  1) Spaces
       should render subspaces in the space panel only when expanded:
     AssertionError: 1 accessibility violation was detected: expected 1 to equal 0
      at Context.eval (webpack://matrix-react-sdk/./node_modules/cypress-axe/dist/index.js:100:0)
@richvdh richvdh added the Z-Flaky-Test A test is raising false alarms label Nov 19, 2023
@richvdh
Copy link
Member Author

richvdh commented Nov 19, 2023

@MidhunSureshR suggests this is an actual longstanding problem, which is only being detected now because, until recently, the tests were being run on Electron and are now being run on Chrome (?)

@richvdh richvdh mentioned this issue Nov 19, 2023
Merged
@t3chguy t3chguy self-assigned this Nov 20, 2023
@t3chguy
Copy link
Member

t3chguy commented Nov 20, 2023

image

@t3chguy t3chguy mentioned this issue Nov 20, 2023
Merged
@florianduros florianduros added S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Testing Testing, code coverage, etc. A-Developer-Experience O-Uncommon Most users are unlikely to come across this or unexpected workflow T-Defect labels Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Developer-Experience A-Testing Testing, code coverage, etc. O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Flaky-Test A test is raising false alarms
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable axe check which only fails in Chrome matrix-org/matrix-react-sdk
3 participants
@richvdh @t3chguy @florianduros