Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation in theming.md seems outdated #26575

Closed
djschilling opened this issue Nov 14, 2023 · 5 comments
Closed

Documentation in theming.md seems outdated #26575

djschilling opened this issue Nov 14, 2023 · 5 comments
Labels
A-Avatar A-Themes-Custom Custom theme variables or support A-Theming O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression Z-Compound Z-Labs

Comments

@djschilling
Copy link

djschilling commented Nov 14, 2023

Steps to reproduce

I wrote a custom config for element web. Changing some colors worked fine. But some of the variables seem to not work anymore as described here.

  • Setting avatar-background-colors does not work
  • accent-color does not work and seems to be replaced by just accent
  • warning-color does not work and i could not find a replacement for it.
  • other variables like quinary-content are working but are not documented

Is there somewhere a complete list of variables that can be used here?
Is it possible to override the letter spacing for the font?

Here is the current state of my theme:

"custom_themes": [
            {
                "name": "ChurchTools",
                "is_dark": false,
                "fonts": {
                    "faces": [
                        {
                            "font-family": "Lato",
                            "src": [
                                {
                                    "url": "/themes/element/lato-v14-latin-ext_latin-regular.woff2",
                                    "format": "woff2"
                                }
                            ]
                        }
                    ],
                    "general": "Lato, sans",
                    "monospace": "'Courier New'"
                },
                "colors": {
                    "accent": "#2563EB",
                    "quinary-content": "#E2E8F0",
                    "warning-color": "#EF4444",
                    "sidebar-color": "#EBEFF5",
                    "roomlist-background-color": "#F1F5F9",
                    "roomlist-text-color": "#0F172A",
                    "roomlist-text-secondary-color": "#475569",
                    "roomlist-highlights-color": "#E2E8F0",
                    "roomlist-separator-color": "#E2E8F0",
                    "timeline-background-color": "#ffffff",
                    "timeline-text-color": "#0F172A",
                    "timeline-text-secondary-color": "#475569",
                    "timeline-highlights-color": "#F1F5F9",
                    "username-colors": [
                        "#0EA5E9",
                        "#22C55E",
                        "#2563EB",
                        "#8B5CF6",
                        "#EAB308",
                        "#EF4444",
                        "#F97316",
                        "#D946EF"
                    ],
                    "avatar-background-colors": [
                        "#22C55E",
                        "#2563EB",
                        "#F97316"
                    ]
                }
            }
        ]
    }
@t3chguy
Copy link
Member

t3chguy commented Nov 14, 2023

Related #26285

@florianduros florianduros added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Uncommon Most users are unlikely to come across this or unexpected workflow X-Regression A-Avatar labels Nov 15, 2023
@t3chguy t3chguy added A-Theming A-Themes-Custom Custom theme variables or support labels Nov 16, 2023
@Johennes
Copy link
Contributor

The whole approach to theming will change with Compound but the concrete details of that still need to be worked out. In the meantime, we should at the minimum add a disclaimer about this known to be broken in the docs.

@zip0zip0
Copy link

Is there a status on when the new 'Theming' and its documentation will be in place?

@Johennes
Copy link
Contributor

I'm not able to answer this anymore, sadly, but @langleyd might be.

@t3chguy
Copy link
Member

t3chguy commented Jun 10, 2024

The docs got fixed at some point

@t3chguy t3chguy closed this as completed Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Avatar A-Themes-Custom Custom theme variables or support A-Theming O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression Z-Compound Z-Labs
Projects
None yet
Development

No branches or pull requests

5 participants