Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't react from search #26557

Closed
fabianunterstell opened this issue Nov 12, 2023 · 3 comments · Fixed by matrix-org/matrix-react-sdk#11996
Closed

Can't react from search #26557

fabianunterstell opened this issue Nov 12, 2023 · 3 comments · Fixed by matrix-org/matrix-react-sdk#11996
Assignees
Labels
A-Reactions A-Timeline-Search O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@fabianunterstell
Copy link

Steps to reproduce

  1. Use the search to find a message.
  2. Use react on the message in the search view to react with an emoji to the message.
  3. Use react on the message in the search view to react with the same emoji to the message again.

Outcome

What did you expect?

After 2. the message should show the emoji as a reaction.
After 3. the message should have the emoji reaction removed again.

What happened instead?

After 2. the message does not show the emoji as reaction. But if you then leave the search view the message does show the reaction correctly.

After 3. the no reaction shows or gets removed and you receive the following error:

Some of your messages have not been sent
You can select all or individual messages to retry or delete
Delete all | Retry all

This seems to be related to: #26508

Operating system

Windows 10

Application version

Element Nightly version: 0.0.1-nightly.2023111201 Crypto version: Olm 3.2.15

How did you install the app?

From element website

Homeserver

Synapse 1.93

Will you send logs?

No

@fabianunterstell
Copy link
Author

On further investigation: The search view does not show react emojis at all. So 2. might be intended behaviour.

But 3. leading to the messages can't be sent error is still an issue.

@HarHarLinks
Copy link
Contributor

I can repro.

After 2. the message should show the emoji as a reaction.

That appears to be the regular behavior, even though I'd argue reactions should be shown during, especially when you're supposed to be able to send them.

@weeman1337
Copy link
Contributor

Related to #26508

@weeman1337 weeman1337 added A-Timeline-Search S-Minor Impairs non-critical functionality or suitable workarounds exist A-Reactions O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Nov 27, 2023
@t3chguy t3chguy self-assigned this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Reactions A-Timeline-Search O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants