Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element-R: when sending a first message in a room some device might be ignored because of recently tracked users not yet downloaded #26439

Closed
BillCarsonFr opened this issue Oct 25, 2023 · 0 comments · Fixed by matrix-org/matrix-js-sdk#3830
Assignees
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Labs Z-UISI Unable to decrypt errors

Comments

@BillCarsonFr
Copy link
Member

Steps to reproduce

  1. Where are you starting? What can you see?

After a login with lazy loading, try to send a message quickly in a room. (in order to reproduce more easily you need the fix for lazy loading problem)

Outcome

What did you expect?

The message to be sent to all devices in the room

What happened instead?

Some users in the room have just been loaded (via a /member call), and marked as tracked. But the key/query has not yet be done (only done at the end of a sync when processing outgoing requests)

This is visible in the logs:

"The user has a pending /key/query request which did
not finish yet, some devices might be missing."

Occurence of this log in rageshakes: https://rageshake-search.tools.element.io/search_logs?log=some+devices+might+be+missing

EX is calling self.query_keys_for_untracked_users().await?; before sharing room keys.

Operating system

macOS

Application version

No response

How did you install the app?

No response

Homeserver

No response

Will you send logs?

No

@BillCarsonFr BillCarsonFr added T-Defect Z-UISI Unable to decrypt errors A-Element-R Issues affecting the port of Element's crypto layer to Rust labels Oct 25, 2023
@BillCarsonFr BillCarsonFr self-assigned this Oct 25, 2023
@robintown robintown added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Labs Z-UISI Unable to decrypt errors
Projects
None yet
2 participants