Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Disabled for Element-R] Flaky cypress test: User verification > can receive a verification request when there is no existing DM #26420

Closed
richvdh opened this issue Oct 23, 2023 · 3 comments · Fixed by matrix-org/matrix-react-sdk#11998
Assignees
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust A-Testing Testing, code coverage, etc. O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist Z-Flaky-Test A test is raising false alarms Z-Labs

Comments

@richvdh
Copy link
Member

richvdh commented Oct 23, 2023

https://github.com/matrix-org/matrix-js-sdk/actions/runs/6612284097/job/17957827303#step:8:303

  1) User verification
       can receive a verification request when there is no existing DM:
     Error: The following error originated from your application code, not from Cypress. It was caused by an unhandled promise rejection.

  > Still no verifier after startSas() call

When Cypress detects uncaught errors originating from your application it will automatically fail the current test.

This behavior is configurable, and you can choose to turn this off by listening to the `uncaught:exception` event.

https://on.cypress.io/uncaught-exception-from-application
      at RustVerificationRequest.startVerification (http://localhost:8080/bundles/be6fdc548b71baaf015c/34.js:2629:13)
      at async (http://localhost:8080/bundles/be6fdc548b71baaf015c/bundle.js:202145:7)
@richvdh richvdh added the Z-Flaky-Test A test is raising false alarms label Oct 23, 2023
@richvdh
Copy link
Member Author

richvdh commented Oct 23, 2023

This is presumably an Element-R issue

@richvdh richvdh added the A-Element-R Issues affecting the port of Element's crypto layer to Rust label Oct 23, 2023
@kerryarchibald
Copy link
Contributor

@Johennes Johennes added the A-Testing Testing, code coverage, etc. label Oct 24, 2023
@weeman1337 weeman1337 added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Oct 25, 2023
@richvdh richvdh changed the title Flaky cypress test: User verification > can receive a verification request when there is no existing DM [Disabled for Element-R] Flaky cypress test: User verification > can receive a verification request when there is no existing DM Oct 26, 2023
@richvdh richvdh self-assigned this Nov 29, 2023
@richvdh
Copy link
Member Author

richvdh commented Nov 29, 2023

The problem here is that sometimes Alice's acceptance of the incoming verification request races with her /keys/query for Bob. Then we get:

WARN matrix_sdk_crypto::verification::requests: Can't create a QR code, the device that accepted the verification doesn't exist
    user_id="@bob_41:localhost" device_id="QTRATQPRBO"
    at /home/rav/work/matrix-rust-sdk/crates/matrix-sdk-crypto/src/verification/requests.rs:1217

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust A-Testing Testing, code coverage, etc. O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist Z-Flaky-Test A test is raising false alarms Z-Labs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants