Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matrix.to link attempts to open Beeper, not Element Desktop, even when clicking on Element #26415

Closed
kongo09 opened this issue Oct 23, 2023 · 6 comments

Comments

@kongo09
Copy link

kongo09 commented Oct 23, 2023

Steps to reproduce

  1. Follow a matrix.to link
  2. Select Element (Desktop) as client

Outcome

What did you expect?

Element Desktop opens and goes to the link

What happened instead?

Browser asks to open Beeper

image

Operating system

Windows 11

Application version

Version von Element: 1.11.46 Version von Olm: 3.2.14

How did you install the app?

Element

Homeserver

element.io

Will you send logs?

No

@t3chguy
Copy link
Member

t3chguy commented Oct 23, 2023

Sounds like both applications register the same protocol handler, you can choose the preferred one in Settings, the app can't force itself nor prevent other apps registering the same handler.

https://support.microsoft.com/en-us/windows/change-default-programs-in-windows-e5d82cad-17d1-c53b-3505-f10a32e1894d

@t3chguy t3chguy closed this as completed Oct 23, 2023
@kongo09
Copy link
Author

kongo09 commented Oct 23, 2023

Apps > Default apps does not register Element or Beeper.

There is also no default file type and no default link type registered with Windows.

This cannot be the problem.

@kongo09 kongo09 reopened this Oct 23, 2023
@t3chguy
Copy link
Member

t3chguy commented Oct 23, 2023

the app can't force itself nor prevent other apps registering the same handler.

Its up to the OS to mediate here, I'd open an issue with Beeper about them registering a handler for element:// when they are not associated with our brand.

image

There is also no default file type and no default link type registered with Windows.

We rely on Electron's behaviour https://www.electronjs.org/docs/latest/api/app#appsetasdefaultprotocolclientprotocol-path-args https://github.com/vector-im/element-desktop/blob/ca0a48196c256f597c25604ff27ddf620ea6ed9b/src/protocol.ts#L103

If this is not working for you then I suggest an issue at https://github.com/electron/electron

In my Windows VM element:// is registered correctly. Where to conflicts between apps in Windows is unknown to me.

Screen.Recording.2023-10-23.at.13.16.04.mov

@t3chguy t3chguy closed this as completed Oct 23, 2023
@kongo09
Copy link
Author

kongo09 commented Oct 23, 2023

I was able to find the following in my registry:

image

If that's the root cause and Beeper registered it there, this is something we should kindly ask them to not do. Maybe that's because they fork Element Desktop in a proprietary way without thinking about this.

Can we please convert this into a feature request for Element Desktop to actively check if it is still registered correctly with the system and if not to offer the user to re-register. That's a behaviour known from browsers that discover that they're no longer default.

@kongo09 kongo09 reopened this Oct 23, 2023
@kongo09
Copy link
Author

kongo09 commented Oct 23, 2023

beeper/self-host#34

@t3chguy
Copy link
Member

t3chguy commented Oct 23, 2023

Can we please convert this into a feature request for Element Desktop to actively check if it is still registered correctly with the system and if not to offer the user to re-register.

We continually re-register via the Electron API I linked above. https://github.com/vector-im/element-desktop/blob/ca0a48196c256f597c25604ff27ddf620ea6ed9b/src/protocol.ts#L103 - any fixes from this side would need to be done in Electron.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants