Flaky cypress test: Cryptography > event shields > should show the correct shield on e2e events

[richvdh]

   1) Cryptography
       event shields
         should show the correct shield on e2e events:
     AssertionError: Timed out retrying after 10000ms: expected '<li.mx_EventTile.mx_EventTile_continuation.mx_EventTile_last.mx_EventTile_lastInSection.mx_EventTile_bad>' to contain 'test encrypted 1'
      at Context.eval (webpack:///./cypress/e2e/crypto/crypto.spec.ts:318:0)

https://github.com/matrix-org/matrix-react-sdk/actions/runs/6379116260/job/17310975290#step:8:21497

[richvdh]

hrm, this actually happened twice on the same PR (matrix-org/matrix-react-sdk#11687), so it might somehow be a problem with that PR rather than a real flaky test.

[richvdh]

Ah, I think the problem is that that test has always been a bit flaky, but up until now it has been masked by the automatic retries. That PR adds even more flakiness so it is no longer masked.

[richvdh]

The problem here seems to be that, even though the to-device message carrying the message key arrived, it wasn't decrypted. It's unclear to me why this might have happened, though it rather looks as though things froze for a while.

[richvdh]

since this hasn't been reported for several months, let's assume for now that it is fixed.