Fix Percy tests for ThreadView on threads.spec.ts
#24883
Labels
A-Testing
Testing, code coverage, etc.
A-Threads
O-Uncommon
Most users are unlikely to come across this or unexpected workflow
S-Major
Severely degrades major functionality or product features, with no satisfactory workaround
T-Defect
Comments
robintown
added
A-Testing
|
Percy tests are gone |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce
The PR matrix-org/matrix-react-sdk#9016 has added Percy tests to detect visual regressions of
EventTiles insideThreadView.Initial ThreadView on group layoutandInitial ThreadView on bubble layoutmatrix-org/matrix-react-sdk@f60f7a1#diff-44347e35ab8f425bcd830646976351b243602f12674e9e306060b0a17697c65bR112-R116-
ThreadView with reaction and a hidden event on group layoutmatrix-org/matrix-react-sdk@f60f7a1#diff-44347e35ab8f425bcd830646976351b243602f12674e9e306060b0a17697c65bR194-R196ThreadView with reaction and a hidden event on bubble layoutmatrix-org/matrix-react-sdk@f60f7a1#diff-44347e35ab8f425bcd830646976351b243602f12674e9e306060b0a17697c65bR216-R218ThreadView with redacted messages on group layoutandThreadView with redacted messages on bubble layoutmatrix-org/matrix-react-sdk@f60f7a1#diff-44347e35ab8f425bcd830646976351b243602f12674e9e306060b0a17697c65bR246-R252Reply to the location on ThreadViewmatrix-org/matrix-react-sdk@f60f7a1#diff-44347e35ab8f425bcd830646976351b243602f12674e9e306060b0a17697c65bR463It turns out they do not really work how they are supposed to.
ThreadView with reaction and a hidden event on bubble layoutReply to the location on ThreadViewThreadView with redacted messages on group layoutThreadView with redacted messages on bubble layoutThreadView with reaction and a hidden event on group layoutInitial ThreadView on bubble layoutInitial ThreadView on group layoutAll of them seem to have taken snapshots of the right panel without their content. They are supposed to take snapshots
ThreadViewincludingEventTiles and a poll.Outcome
What did you expect?
They should take snapshots of contents inside
ThreadView.What happened instead?
They take snapshots of the
ThreadViewwithout its content such asEventTiles, redacted messages placeholder, etc. on modern layout and bubble layout (note that there is not IRC layout onThreadView).Operating system
No response
Browser information
No response
URL for webapp
No response
Application version
develop branch
Homeserver
No response
Will you send logs?
No
The text was updated successfully, but these errors were encountered: