Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking on user names in the thread view will cause jumps in the timeline #21672

Closed
janogarcia opened this issue Apr 4, 2022 · 1 comment
Closed

Clicking on user names in the thread view will cause jumps in the timeline #21672

janogarcia opened this issue Apr 4, 2022 · 1 comment
Labels
A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Labs

Comments

@janogarcia
Copy link

Steps to reproduce

When viewing a thread, click on a user name.

Outcome

What did you expect?

Same behavior as in the main timeline (i.e., adds a user pill in the composer, without introducing any unexpected jump in the timeline position).

What happened instead?

  • When clicking on the root message's author name it will jump to that message position in the main timeline.
  • When clicking on a non-root message author name it will center the position of the message in the thread timeline (needs to be tested on a long thread)

Operating system

macOS

Browser information

Chrome

URL for webapp

develop.element.io

Application version

Element version: b79133c-react-371ccd78580f-js-b8321290f823 Olm version: 3.2.8

Homeserver

No response

Will you send logs?

No
@github-actions github-actions bot added the Z-Labs label Apr 4, 2022
@dbkr dbkr added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Apr 5, 2022
@robintown
Copy link
Member

Fixed by matrix-org/matrix-react-sdk#8149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Labs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@janogarcia @dbkr @robintown