Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't try to url preview pdfs as if they were html #1463

Closed
matrixbot opened this issue Apr 27, 2016 · 5 comments
Closed

don't try to url preview pdfs as if they were html #1463

matrixbot opened this issue Apr 27, 2016 · 5 comments
Labels
A-URL-Previews Help Wanted Extra attention is needed P2 S-Tolerable Low/no impact on users T-Defect

Comments

@matrixbot
Copy link

Created by @ matthew:matrix.org.
@ara4n ara4n added T-Defect P1 S-Tolerable Low/no impact on users P2 and removed P1 labels Apr 28, 2016
@ara4n
Copy link
Member

ara4n commented Apr 28, 2016

n.b. don't try to repro this against matrix.org, which is still blacklisted

@ara4n
Copy link
Member

ara4n commented Apr 28, 2016

good example: https://cryptojedi.org/papers/mukummer-20160407.pdf

@aviraldg aviraldg added the easy label Jul 17, 2016
@ara4n ara4n changed the title don't try to url preview pdfs don't try to url preview pdfs as if they were html Dec 19, 2017
@eMPee584
Copy link

While I think this issue has been solved: is there any solution yet for PDF previews?

@t3chguy
Copy link
Member

t3chguy commented Apr 22, 2020

from URLs or from being sent in the room?

@SimonBrandner SimonBrandner added Help Wanted Extra attention is needed and removed Easy labels Aug 26, 2021
@MadLittleMods
Copy link
Contributor

I guess we can close this. It looks like we don't try to thumbnail or preview a linked or uploaded PDF. It's unclear if this issue was just to remove wrong preview or to add a preview for PDF's as @eMPee584 is asking for. This is sorta tracked also by #17072 so I'll just close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-URL-Previews Help Wanted Extra attention is needed P2 S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@aviraldg @jryans @MadLittleMods @eMPee584 @ara4n @t3chguy @matrixbot @SimonBrandner