Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New cross-signing device doesn't trust itself #12884

Closed
tleydxdy opened this issue Mar 26, 2020 · 6 comments
Closed

New cross-signing device doesn't trust itself #12884

tleydxdy opened this issue Mar 26, 2020 · 6 comments
Labels
A-E2EE-Cross-Signing O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter

Comments

@tleydxdy
Copy link

tleydxdy commented Mar 26, 2020

Description

Upon starting a new session, riot didn't prompt me to enter my secret storage password, but it trusted every device I got except itself. Clicking manual verify just spins forever.

Steps to reproduce

Unclear

Logs being sent: no, Failed to send logs: HTTP 0

Version information

  • Platform: web

For the web app:

  • Browser: Firefox 74.0
  • OS: Arch
  • URL: self-hosted 1.5.13
@tleydxdy
Copy link
Author

for completeness, here's my config.json

{
    "default_server_config": {
        "m.homeserver": {
            "base_url": "https://synapse.tlebear.win",
            "server_name": "tlebear.win"
        }
    },
    "disable_custom_urls": true,
    "disable_guests": true,
    "disable_login_language_selector": false,
    "disable_3pid_login": true,
    "brand": "Riot",
    "bug_report_endpoint_url": "https://riot.im/bugreports/submit",
    "defaultCountryCode": "CN",
    "showLabsSettings": true,
    "features": {
        "feature_pinning": "labs",
        "feature_custom_status": "labs",
        "feature_custom_tags": "labs",
        "feature_state_counters": "labs",
	"feature_dm_verification": "labs",
	"feature_cross_signing": "enable",
	"feature_event_indexing": "disable",
	"feature_bridge_state": "labs",
	"feature_presence_in_room_list": "enable"
    },
    "default_federate": true,
    "default_theme": "dark",
    "roomDirectory": {
        "servers": [
            "matrix.org",
            "tlebear.win"
        ]
    },
    "enable_presence_by_hs_url": {
        "https://matrix.org": false,
        "https://matrix-client.matrix.org": false
    },
    "settingDefaults": {
        "breadcrumbs": true
    }
}

@dbkr
Copy link
Member

dbkr commented Mar 26, 2020

Is this reproducible on the develop branch? Cross signing is in very active development so the 1.5.13 release code is quite stale at this point.

@tleydxdy
Copy link
Author

@dbkr Is there a place I can get a build of the dev branch?

@jryans
Copy link
Collaborator

jryans commented Mar 27, 2020

@tleydxdy https://riot.im/develop is the easiest way to access it. It's updated every time a change is merged.

@tleydxdy
Copy link
Author

@jryans I was having trouble with it logging me out when ever my internet becomes bad (happened mutiple time) therefore why I tried to host it myself. maybe I should make a issue about that too

@ara4n ara4n changed the title New cross-signing device does trust itself New cross-signing device doesn't trust itself Apr 17, 2020
@MadLittleMods MadLittleMods added X-Needs-Info This issue is blocked awaiting information from the reporter A-E2EE-Cross-Signing S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Aug 25, 2022
@robintown robintown reopened this Aug 29, 2022
@richvdh
Copy link
Member

richvdh commented Oct 8, 2024

This issue looks like it's bitrotted. I doubt it's still happening.

@richvdh richvdh closed this as completed Oct 8, 2024
t3chguy pushed a commit that referenced this issue Oct 17, 2024
#12884)

* Refactor the various email/phone management UI into a single component

These were basically the same component copied & pasted 3 times and
tweaked to match the behaviour of each case. This de-dupes them into
one component.

This all could really benefit from playwright tests, but would require
setting up a dummy ID server in the playwright tests. This is all legacy
pre-MAS stuff so its questionable whether its worth the effort.

* Basic test, remove old tests

* Use different text to confirm remove & put headers back

although the two texts are both 'Remove' in practice

* Remove string

This was never triggered anyway with sydent & synapse because they
don't seem to agree on what error to return. In any case, I think it
makes more sense for it to be consistent with the email path, ie. using
a dialog.

* Avoid nested forms

* Snapshots

* More snapshots

* Test the hs side

* Snapshots

* Test IS bind/revoke

* Test remove can be cancelled

* Test unvalidated cases & fix phone error

* Reset state between tests

* Import useState directly

* One more direct React import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE-Cross-Signing O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter
Projects
None yet
Development

No branches or pull requests

6 participants