-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement youtube embeds #1220
Comments
Maybe use a dep like https://github.com/troybetz/react-youtube ? |
Being able to watch youtube and other videos in the in-line chat window is a very big convenience experienced by others using Discord and other such alternatives. I really want to see this in Riot as I'm looking to set this up for us (on-prem). |
/me adds to Todo List |
Any word on this? :S Perhaps can we get this set to a milestone? |
I'll revive this tomorrow I already had it working. |
Pssst, any word @t3chguy ? :) |
I have to merge it with Dave's old efforts to form some generic behemoth - it'll be after exams (3-4 weeks or so) |
How about oembed (YouTube supports it)? That would open up preview for a lot of sites. |
Sorry, do we know anything about the youtube preview support? Thanks. |
I too am curious. |
I'd love to know this as well |
My work on this bitrotted too much |
@t3chguy surely something can be salvaged? |
It's currently being pursued as https://github.com/vector-im/riot-web/issues/10060 (in fact, the demo was with youtube embeds) |
That doesn't sound like the best UX though, means you have to use a compatible client and send a specially formatted message instead of just a plaintext YouTube URL |
(there's no reason why we can't convert events for better UX like this) |
ah okay, I was just speculating based on the intro of the MSC, did not look through the code |
Currently there are YouTube previews, but no embedded player. Implement an opt-in for this to compete effectively.
There should be a warning about risks involved in running YouTube's JS in the app page.
iframe possible to cordon off access to parent JS environment?
The text was updated successfully, but these errors were encountered: