Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement youtube embeds #1220

Open
OliverUv opened this issue Mar 18, 2017 · 18 comments · Fixed by SchildiChat/matrix-react-sdk#3
Open

Implement youtube embeds #1220

OliverUv opened this issue Mar 18, 2017 · 18 comments · Fixed by SchildiChat/matrix-react-sdk#3

Comments

@OliverUv
Copy link

OliverUv commented Mar 18, 2017

Currently there are YouTube previews, but no embedded player. Implement an opt-in for this to compete effectively.

There should be a warning about risks involved in running YouTube's JS in the app page.

iframe possible to cordon off access to parent JS environment?

@lampholder lampholder added the P3 label Mar 20, 2017
@MTRNord
Copy link

MTRNord commented Jun 28, 2017

Maybe use a dep like https://github.com/troybetz/react-youtube ?

@BloodyIron
Copy link

Being able to watch youtube and other videos in the in-line chat window is a very big convenience experienced by others using Discord and other such alternatives. I really want to see this in Riot as I'm looking to set this up for us (on-prem).

@t3chguy
Copy link
Member

t3chguy commented Aug 27, 2017

/me adds to Todo List

@BloodyIron
Copy link

BloodyIron commented Nov 27, 2017

Any word on this? :S

Perhaps can we get this set to a milestone?

@t3chguy
Copy link
Member

t3chguy commented Nov 27, 2017

I'll revive this tomorrow I already had it working.

@BloodyIron
Copy link

Pssst, any word @t3chguy ? :)

@t3chguy
Copy link
Member

t3chguy commented Jan 10, 2018

I have to merge it with Dave's old efforts to form some generic behemoth - it'll be after exams (3-4 weeks or so)

@fuzzy76
Copy link

fuzzy76 commented Mar 27, 2018

How about oembed (YouTube supports it)? That would open up preview for a lot of sites.

@Arritmic
Copy link

Arritmic commented Feb 5, 2019

Sorry, do we know anything about the youtube preview support? Thanks.

@BloodyIron
Copy link

I too am curious.

@dotMavriQ
Copy link

I'd love to know this as well

@t3chguy
Copy link
Member

t3chguy commented Sep 6, 2019

My work on this bitrotted too much

@BloodyIron
Copy link

@t3chguy surely something can be salvaged?

@turt2live
Copy link
Member

It's currently being pursued as https://github.com/vector-im/riot-web/issues/10060 (in fact, the demo was with youtube embeds)

@t3chguy
Copy link
Member

t3chguy commented Sep 6, 2019

That doesn't sound like the best UX though, means you have to use a compatible client and send a specially formatted message instead of just a plaintext YouTube URL

@turt2live
Copy link
Member

(there's no reason why we can't convert events for better UX like this)

@t3chguy
Copy link
Member

t3chguy commented Sep 6, 2019

ah okay, I was just speculating based on the intro of the MSC, did not look through the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants