Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Importing a large (300MB) megolm backup into EDR fails #1394

Closed
ara4n opened this issue Dec 4, 2023 · 3 comments
Closed

Importing a large (300MB) megolm backup into EDR fails #1394

ara4n opened this issue Dec 4, 2023 · 3 comments
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Critical Prevents work, causes data loss and/or has no workaround T-Defect Z-Labs

Comments

@ara4n
Copy link
Member

ara4n commented Dec 4, 2023

Steps to reproduce

  1. Import a 300MB key backup into a fresh EDR profile
  2. The UI shows the import dialog with the submit button greyed out (having hit submit)
  3. Nothing happens.
  4. In the JS console, after 5 minutes or so, you see:
13:06:20.436 rageshake.ts:74 INFO matrix_sdk_crypto::store: Successfully imported room keys
    total_count=415039 imported_count=415029 room_keys={"!AAxKAMhBXmmnFncGWK:matrix.org": {"ClkpiJX+Vedx1lArJ1WrPBm7oaeh2RqBstJ3ddolrwI": {"53PNM6WvWav/Xu6B5pszN9yFsaDZgzDXN6lqWhJCDWQ"},...

However, the dialog box never goes away.

After about 20 minutes, the app OOMs in v8, and then OOMs within about 10s of launch on every subsequent launch.

I had to throw the profile away.

Outcome

What did you expect?

Ability to import key backup.

What happened instead?

Either it failed, or it OOMed, or both.

Operating system

No response

Application version

EDR Nightly 2023120401

How did you install the app?

No response

Homeserver

No response

Will you send logs?

Yes
@ara4n ara4n added the T-Defect label Dec 4, 2023
@richvdh richvdh added the A-Element-R Issues affecting the port of Element's crypto layer to Rust label Dec 4, 2023
@github-actions github-actions bot added the Z-Labs label Dec 4, 2023
@dbkr dbkr added S-Critical Prevents work, causes data loss and/or has no workaround O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Dec 5, 2023
@ara4n ara4n mentioned this issue Dec 7, 2023
Closed
@richvdh richvdh mentioned this issue Dec 12, 2023
Closed
@richvdh
Copy link
Member

richvdh commented Dec 13, 2023

Strongly suspect the OOMing has been fixed by matrix-org/matrix-js-sdk#3934, though it probably also needs element-hq/element-web#26488 to be properly fixed.

@andybalaam andybalaam assigned andybalaam and unassigned andybalaam Dec 13, 2023
@ara4n
Copy link
Member Author

ara4n commented Dec 16, 2023 •
edited
Loading

I was just able to import my big offline backup into EDR, and it hasn't OOMed yet! (EWR crashed immediately however with an 'Aw snap').

However, having imported it, EDR is failing to encrypt/send msgs in Crypto Internal - have rageshaked (element-hq/element-web#26783)

@ara4n ara4n mentioned this issue Dec 18, 2023
Closed
@t3chguy t3chguy transferred this issue from element-hq/element-web Dec 16, 2023
@richvdh
Copy link
Member

richvdh commented Dec 18, 2023

declaring this particular failure mode fixed then.

@richvdh richvdh closed this as completed Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Critical Prevents work, causes data loss and/or has no workaround T-Defect Z-Labs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@andybalaam @dbkr @ara4n @richvdh