From e193923420894f11ec77652c41ed1c435b26cb2d Mon Sep 17 00:00:00 2001 From: Mark Lee Date: Tue, 7 Jul 2020 18:26:51 -0700 Subject: [PATCH] build: replace AppVeyor with CircleCI Windows support (#343) * docs: note that top-level await doesn't work with Node 12 --- .circleci/config.yml | 11 ++++++++++- README.md | 2 ++ appveyor.yml | 24 ------------------------ 3 files changed, 12 insertions(+), 25 deletions(-) delete mode 100644 appveyor.yml diff --git a/.circleci/config.yml b/.circleci/config.yml index 9e81fac..947dbbf 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -73,7 +73,9 @@ steps-mac: &steps-mac - *step-save-cache - run: yarn test -version: 2 +version: 2.1 +orbs: + win: circleci/windows@1.0.0 jobs: test-linux: docker: @@ -83,6 +85,11 @@ jobs: macos: xcode: "11.1.0" <<: *steps-mac + test-windows: + executor: + name: win/vs2019 + shell: bash.exe + <<: *steps-linux-win release: docker: @@ -99,10 +106,12 @@ workflows: jobs: - test-linux - test-mac + - test-windows - release: requires: - test-linux - test-mac + - test-windows filters: branches: only: diff --git a/README.md b/README.md index af68460..7a58c32 100644 --- a/README.md +++ b/README.md @@ -24,6 +24,8 @@ const electronInstaller = require('electron-winstaller'); Then do a build like so.. ```javascript +// NB: Use this syntax within an async function, Node does not have support for +// top-level await as of Node 12. try { await electronInstaller.createWindowsInstaller({ appDirectory: '/tmp/build/my-app-64', diff --git a/appveyor.yml b/appveyor.yml deleted file mode 100644 index 0beb221..0000000 --- a/appveyor.yml +++ /dev/null @@ -1,24 +0,0 @@ -branches: - only: - - master - -skip_tags: true - -init: - - git config --global core.autocrlf input - -environment: - matrix: - - nodejs_version: 8 - -install: - - ps: Update-NodeJsInstallation (Get-NodeJsLatestBuild $env:nodejs_version) - - git clean -xdf - - yarn install --ignore-engines - -build: off - -test_script: - - node --version - - yarn --version - - yarn test