Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ekapkgs] Have derivation helpers overwrite overrideAttrs #21

Open
jonringer opened this issue Dec 9, 2024 · 0 comments
Open

[Ekapkgs] Have derivation helpers overwrite overrideAttrs #21

jonringer opened this issue Dec 9, 2024 · 0 comments

Comments

@jonringer
Copy link
Contributor

In nixpkgs today, we have many mkDerivation "helpers" which expose a facade to mkDerivation. Instead of having overrideAttrs just affect the attrs which were passed to mkDerivation, I would instead prefer for the mkDerivation's overrideAttrs to be replaced by the downstream helper.

The goal is to make the interface which was used by an individual to be most reflective of what overrideAttrs would be targeting.

Specifically:

  • mkDerivation should alias the current .overrideAttrs function to .overrideMkDerivationAttrs
    • overrideAttrs still exists
  • "mkDerivation helpers" (e.g. buildPythonPackage) will overwrite .overrideAttrs with their own usage.
    • They can also expose their specific override attrs as well (E.g. overridePythonAttrs).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant