Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make importing more parallel #386

Closed
Mr0grog opened this issue Sep 14, 2018 · 3 comments
Closed

Make importing more parallel #386

Mr0grog opened this issue Sep 14, 2018 · 3 comments

Comments

@Mr0grog
Copy link
Member

Mr0grog commented Sep 14, 2018

The current import process is entirely serial and runs record-by-record. When there’s a lot of downloading & archiving to do, that can make it pretty slow. Instead, we could make multiple passes that would let potentially do a lot of the work in parallel:

  1. Find and add all new tags and maintainers (so we aren’t checking the DB for whether they exist on every record)
  2. Group records by URL and capture time
  3. Execute each of the groups above in parallel (or at least a sizable pool of threads). I’m reasonably sure nothing other than tags and maintainers should be shared across URLs right now.

Not high priority right now — even if our imports are slow, they are plenty fast enough for our current needs.

@stale
Copy link

stale bot commented Mar 13, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in seven days if no further activity occurs. If it should not be closed, please comment! Thank you for your contributions.

@stale stale bot added the stale label Mar 13, 2019
@stale stale bot closed this as completed Mar 20, 2019
@danielballan danielballan reopened this Mar 24, 2019
@stale stale bot removed the stale label Mar 24, 2019
@Mr0grog
Copy link
Member Author

Mr0grog commented Mar 25, 2019

Given the non-emergency nature of this, I think we should probably not worry about doing until after (or as a part of) #119.

@stale
Copy link

stale bot commented Sep 21, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in seven days if no further activity occurs. If it should not be closed, please comment! Thank you for your contributions.

@stale stale bot added the stale label Sep 21, 2019
@stale stale bot closed this as completed Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants