From 0a055cd77fe7bbd0f5503e4c17b6ffe6d06a35f4 Mon Sep 17 00:00:00 2001 From: tiger_fu Date: Wed, 3 Jul 2024 10:26:10 +0800 Subject: [PATCH] [Platform][AS7326-56X]: Fix status led test failed for FAN and PSU. Why I did it: sonic-mgmt pytest failed on - platform_tests/api/test_chassis_fans.py::TestChassisFans::test_set_fans_led - platform_tests/api/test_fan_drawer.py::TestFanDrawerApi::test_set_fan_drawers_led - platform_tests/api/test_fan_drawer_fans.py::TestFanDrawerFans::test_set_fans_led - platform_tests/api/test_psu.py::TestPsuApi::test_led How I dit it: Correct settings for platform.json because the status LEDs for PSU and FAN are uncontrollable. How to verify it: Re-run the pytest and the result is pass. --- .../x86_64-accton_as7326_56x-r0/platform.json | 106 +++++++++++++++++- 1 file changed, 104 insertions(+), 2 deletions(-) diff --git a/device/accton/x86_64-accton_as7326_56x-r0/platform.json b/device/accton/x86_64-accton_as7326_56x-r0/platform.json index 99dd8305c..3e96d8b09 100644 --- a/device/accton/x86_64-accton_as7326_56x-r0/platform.json +++ b/device/accton/x86_64-accton_as7326_56x-r0/platform.json @@ -28,6 +28,9 @@ "speed": { "controllable": true, "minimum": 32 + }, + "status_led": { + "controllable": false } }, { @@ -35,6 +38,9 @@ "speed": { "controllable": true, "minimum": 32 + }, + "status_led": { + "controllable": false } }, { @@ -42,6 +48,9 @@ "speed": { "controllable": true, "minimum": 32 + }, + "status_led": { + "controllable": false } }, { @@ -49,6 +58,9 @@ "speed": { "controllable": true, "minimum": 32 + }, + "status_led": { + "controllable": false } }, { @@ -56,6 +68,9 @@ "speed": { "controllable": true, "minimum": 32 + }, + "status_led": { + "controllable": false } }, { @@ -63,6 +78,9 @@ "speed": { "controllable": true, "minimum": 32 + }, + "status_led": { + "controllable": false } }, { @@ -70,6 +88,9 @@ "speed": { "controllable": true, "minimum": 32 + }, + "status_led": { + "controllable": false } }, { @@ -77,6 +98,9 @@ "speed": { "controllable": true, "minimum": 32 + }, + "status_led": { + "controllable": false } }, { @@ -84,6 +108,9 @@ "speed": { "controllable": true, "minimum": 32 + }, + "status_led": { + "controllable": false } }, { @@ -91,6 +118,9 @@ "speed": { "controllable": true, "minimum": 32 + }, + "status_led": { + "controllable": false } }, { @@ -98,6 +128,9 @@ "speed": { "controllable": true, "minimum": 32 + }, + "status_led": { + "controllable": false } }, { @@ -105,12 +138,18 @@ "speed": { "controllable": true, "minimum": 32 + }, + "status_led": { + "controllable": false } } ], "fan_drawers":[ { "name": "FanTray1", + "status_led": { + "controllable": false + }, "num_fans" : 2, "fans": [ { @@ -118,6 +157,9 @@ "speed": { "controllable": true, "minimum": 32 + }, + "status_led": { + "controllable": false } }, { @@ -125,12 +167,18 @@ "speed": { "controllable": true, "minimum": 32 + }, + "status_led": { + "controllable": false } } ] }, { "name": "FanTray2", + "status_led": { + "controllable": false + }, "num_fans" : 2, "fans": [ { @@ -138,6 +186,9 @@ "speed": { "controllable": true, "minimum": 32 + }, + "status_led": { + "controllable": false } }, { @@ -145,12 +196,18 @@ "speed": { "controllable": true, "minimum": 32 + }, + "status_led": { + "controllable": false } } ] }, { "name": "FanTray3", + "status_led": { + "controllable": false + }, "num_fans" : 2, "fans": [ { @@ -158,6 +215,9 @@ "speed": { "controllable": true, "minimum": 32 + }, + "status_led": { + "controllable": false } }, { @@ -165,12 +225,18 @@ "speed": { "controllable": true, "minimum": 32 + }, + "status_led": { + "controllable": false } } ] }, { "name": "FanTray4", + "status_led": { + "controllable": false + }, "num_fans" : 2, "fans": [ { @@ -178,6 +244,9 @@ "speed": { "controllable": true, "minimum": 32 + }, + "status_led": { + "controllable": false } }, { @@ -185,12 +254,18 @@ "speed": { "controllable": true, "minimum": 32 + }, + "status_led": { + "controllable": false } } ] }, { "name": "FanTray5", + "status_led": { + "controllable": false + }, "num_fans" : 2, "fans": [ { @@ -198,6 +273,9 @@ "speed": { "controllable": true, "minimum": 32 + }, + "status_led": { + "controllable": false } }, { @@ -205,12 +283,18 @@ "speed": { "controllable": true, "minimum": 32 + }, + "status_led": { + "controllable": false } } ] }, { "name": "FanTray6", + "status_led": { + "controllable": false + }, "num_fans" : 2, "fans": [ { @@ -218,6 +302,9 @@ "speed": { "controllable": true, "minimum": 32 + }, + "status_led": { + "controllable": false } }, { @@ -225,6 +312,9 @@ "speed": { "controllable": true, "minimum": 32 + }, + "status_led": { + "controllable": false } } ] @@ -233,9 +323,15 @@ "psus": [ { "name": "PSU-1", + "status_led": { + "controllable": false + }, "fans": [ { - "name": "PSU-1 FAN-1" + "name": "PSU-1 FAN-1", + "status_led": { + "controllable": false + } } ], "thermals": [ @@ -253,9 +349,15 @@ }, { "name": "PSU-2", + "status_led": { + "controllable": false + }, "fans": [ { - "name": "PSU-2 FAN-1" + "name": "PSU-2 FAN-1", + "status_led": { + "controllable": false + } } ], "thermals": [