Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuickDiff for embedded text documents #2624

Open
mx990 opened this issue Dec 12, 2024 · 0 comments
Open

QuickDiff for embedded text documents #2624

mx990 opened this issue Dec 12, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@mx990
Copy link
Contributor

mx990 commented Dec 12, 2024

We at Eclipse 4diac are using a text editor tab inside a multi-page editor for text documents embedded inside XML files. The plain-text content is extracted out of the larger XML file via a custom document provider.

The default QuickDiff reference source reads the file contents directly, without going through the document provider of the editor. In our use case, this unfortunately leads to bogus differences for the XML content surrounding the plain-text embeddings. We have thus decided to disable QuickDiff in our embedded text editors for now.

I would like to suggest using the document provider of the editor to obtain the reference document instead of loading it directly. To that end, I would suggest adding a new interface IQuickDiffDocumentProvider, optionally implemented by document providers allowing them to provide a custom reference document. Of course, I am also open to other ideas for solving the problem.

I am hoping for a constructive discussion on possible solutions, after which I would also be happy to implement the feature myself if possible and reasonable.

@mx990 mx990 added the enhancement New feature or request label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant