Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark theme - Reduce colors in form based editor #2555

Closed
vogella opened this issue Nov 28, 2024 · 3 comments
Closed

Dark theme - Reduce colors in form based editor #2555

vogella opened this issue Nov 28, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@vogella
Copy link
Contributor

vogella commented Nov 28, 2024 •
edited
Loading

IMHO we should use less colors in the new dark theme #2114 in form based editors. For example in the MANIFEST.MF editor.

image

@BeckerWdf @mvm-sap @thomasritter WDYT?
@vogella vogella added the enhancement New feature or request label Nov 28, 2024
@vogella
Copy link
Contributor Author

vogella commented Nov 28, 2024

Areas for improvement:

Dark spacing between elements (marked in the screenshot):

image

Form header background

image

@mvm-sap
Copy link
Contributor

mvm-sap commented Dec 2, 2024

This is a Linux-only issue, but it looks fine in Windows. Will check and fix it.

@mvm-sap mvm-sap mentioned this issue Dec 3, 2024
Merged
@vogella
Copy link
Contributor Author

vogella commented Dec 4, 2024

Thanks @mvm-sap

@vogella vogella closed this as completed Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vogella @mvm-sap