Modifying MANIAC-V2 corrupts it

[dwatteau]

When just applying this to MANIAC-PC-V2, without any other change:

scummrp -gp maniacv2 . -od DUMP # export
scummrp -gp maniacv2 . -id DUMP # reimport the same dump

…scummrp seems to corrupt the game, because right after this, the game always starts in demo mode, at least in ScummVM. This problem also happens with the 0.4.0 scummrp.exe executable.

With a more verbose export, the following warnings appear:

17.LFL should actually end at 0x1F3B
Removed (33, 0x3E77) from the index
Removed (41, 0x160F) from the index
OIv2_0395 might actually be OIv2_0547 (unlikely)

but the first warning about 17.LFL is different on the French version of Maniac Mansion v2.

Removed (17, 0x1F3B) from the index
Removed (33, 0x3E77) from the index
Removed (41, 0x160F) from the index
OIv2_0395 might actually be OIv2_0547 (unlikely)

It appears that the original English v2 version of Maniac Mansion has more script bugs than the one already discovered in #12.

This ScummRP bug is potentially responsible for the fact that PR #14 still doesn't completely fix our ScummTR bug with the same variant of the game.

[dwatteau]

So, the bug is not only in the English V2 version of Maniac Mansion; I can also reproduce it with my French V2 version (included in my DOTT CDs). I think some Italian translators hit this bug, too.

[dwatteau]

There's probably something wrong in the V2 parser. Zak appears OK, but it still gives some warnings and has some FIXMEs. Reimporting an official translation inside Zak also produces different LFL files.

AFAIK, scummtr always behaved this way.

So, we probably have a bug or some limitations here, but I don't know how to fix that. ScummTR 0.5.1 will just disable support for MANIAC-V2 modifications.

[dwatteau]

Someone on oldgamesitalia reported that this bug makes the Italian Amiga version glitch in some way, unless you fix some offsets:

https://www.oldgamesitalia.net/forum/index.php?s=&showtopic=18982&view=findpost&p=385373

to fix the bug [with the Italian Maniac V2 Amiga version], you must substitute the following 4 bytes in file 45.LFL

offset 2a: from FF to 92
offset 2b: from FF to eb
offset 2c: from FF to 92
offset 2d: from FF to eb

basically, xor with ff (e.g. $eb92 xor $ffff = $146d) the offsets from which the graphics of object 8 and object 9 that make up the animation of the first character start

I got the correct values from the English version (or some other version)