OpticalDiskDriveLetter: DVD Drive for Windows Server Gen2 (UEFI) OS Images filtered #285
Comments
PlagueHO
added
bug
|
Sample device IDs: Azure Gen1 (BIOS) VM – Windows Server 2022 21H2 Azure Gen2 (UEFI) VM – Windows Server 2022 Azure Edition 21H2 |
|
Working on this now @AjKundnani - I'll aim to submit PR tomorrow or the next day (as haven't had the time to finish it tonight). |
|
@AjKundnani - can you confirm how you're mounting the OD in the Azure VM? I've spun one up to do some further investigation, but need to know the process you're following to create the Virtual DVD-ROM. From looking at the DeviceID, it matches the pattern of an ISO that has been mounted rather than a Virtual DVD-ROM, so it is difficult to differentiate between a mounted ISO and a Virtual DVD-ROM. |
@PlagueHO - The Virtual DVD-ROM is added by default at time of Azure VM creation. It's not being added manually. |
|
Additional mounted ISO properties: |
|
I've been working on a better way to determine if a CIM Win32_CDROMDrive device is a mounted ISO or a virtualized device that is managed by the Host OS. It looks like the current method (using Caption + DeviceID length) just isn't reliable anymore. I put together a table and this is what I came up with:
The first item in the table should not be managed by DSC_OpticalDiskDriveLetter (instead managed by DSC_MountImage). I don't think this is specifically an Azure issue. One technique I have found that might detect if the device is a mounted ISO is to:
Notes: There are no other differences in win32_cdromdrive when the same ISO is mounted using This is still not elegant - but it should work (where the existing method really doesn't any more). If no objections (or better suggestions), I'll implement later tonight. |
…ow a mounted ISO is detected. This resolves issues with using the resource in Azure Gen2 VMs with Windows Server 2022 Azure Edition - Fixes [Issue dsccommunity#285](dsccommunity#285)
|
Still working on this. I've completely removed the use of Caption and DeviceID from being used to detect an ISO as it's completely unreliable after I ran tests across HyperV and Azure. I've replaced it with this function: <#
.SYNOPSIS
This helper function determines if an optical disk can be managed
or not by this resource.
.PARAMETER OpticalIdsk
The cimv2:Win32_CDROMDrive instance of the optical disk that should
be checked.
.OUTPUTS
System.Boolean
.NOTES
This function will use the following logic when determining if a drive is
a mounted ISO and therefore should **not** be mnanaged by this resource:
- Get the Drive letter assigned to the drive in the `cimv2:Win32_CDROMDrive`
instance
- If the drive letter is set, query the volume information for the device
using drive letter and get the device path.
- Look up the disk image using the device path.
- If no error occurs then the device is a mounted ISO and should not be
used with this resource.
If a "The specified disk is not a virtual disk." error occurs then it
is not an ISO and can be managed by this resource.
#>
function Test-OpticalDiskCanBeManaged
{
[CmdletBinding()]
[OutputType([System.Boolean])]
param
(
[Parameter(Mandatory = $true)]
[Microsoft.Management.Infrastructure.CimInstance]
$OpticalDisk
)
$diskCanBeManaged = $false
$driveLetter = ($OpticalDisk.Drive -replace ":$")
$devicePath = (Get-Volume -DriveLetter $driveLetter).Path -replace "\\$"
try
{
<#
If the device is not a mounted ISO then this will throw an
exception with the message "The specified disk is not a virtual disk."
#>
Get-DiskImage -DevicePath $devicePath -ErrorAction Stop | Out-Null
}
catch [Microsoft.Management.Infrastructure.CimException]
{
if ($_.Exception.MessageId -eq 'HRESULT 0xc03a0015')
{
# This is not a mounted ISO, so can manage
$diskCanBeManaged = $true
}
}
return $diskCanBeManaged
}But will need to build a new suite of unit tests to validate. |
|
@AjKundnani - the PR has been created. Recommend you pull my branch (https://github.com/PlagueHO/StorageDsc/tree/Issue-285) down onto your Azure VMs and run the integration tests with: .\build.ps1 -Tasks Build -ResolveDependency
invoke-Pester -Script .\tests\Integration\DSC_OpticalDiskDriveLetter.Integration.Tests.ps1You may need to enable PS remoting on the VM with |
Getting below error: |
#285 (#286) - OpticalDiskDriveLetter: - Fix detection of virtual optical drives by changing logic to detect how a mounted ISO is detected. This resolves issues with using the resource in Azure Gen2 VMs with Windows Server 2022 Azure Edition - Fixes (issue #285). - Azure DevOps Build Pipeline: - Tests 'Unit (Windows Server 2022)' corrected to execute on Windows Server 2022 node instead of Windows Server 2019. - 'Package Module' job runs on 'windows-latest' hosted agent to resolve 'Unable to load shared library 'libmi' or one of its dependencies.' error. - Disk: - Fixed unit test failure loading `StorageDsc.Common.strings` due to change in `DscResource.Common\Get-LocalizationData` in PR #109.
|
@AjKundnani - that is strange that you got that error. I'll give it a try later on today. But in the meantime, this PR has been merged and a new preview version is available (thanks @johlju for reviewing!): https://www.powershellgallery.com/packages/StorageDsc/6.0.0-preview0002 @bbonaby - Should I wait to get your PR #279 merged before releasing 6.0.0 final? I don't think your PR is a breaking change though, so we can always release your one as 6.1.0. |
@PlagueHO - Validated the preview release successfully with DVD Drive & ISO mounted. Mounted ISO was not impacted by the change. |
|
Hi @AjKundnani - a production release has just been published: https://www.powershellgallery.com/packages/StorageDsc/6.0.0 |
Problem description
Windows Server Gen2 OS Images (like Windows Server 2022 Azure Edition) use caption Microsoft Virtual DVD-ROM for optical drives.
This caption is getting filtered with DSC_OpticalDiskDriveLetter causing DSC to skip the drive letter assignment for Optical drives in Gen2 OS images.
This issue is not occurring for Gen1 (BIOS) OS images as DVD drive caption is “Msft Virtual CD/ROM ATA Device”
Verbose logs
DSC configuration
LocalConfigurationManager { ConfigurationModeFrequencyMins = 60 ConfigurationMode = 'ApplyAndAutoCorrect' RebootNodeIfNeeded = $false AllowModuleOverwrite = $true DebugMode = 'ForceModuleImport' } OpticalDiskDriveLetter MoveOpticalDrive { DiskId = 1 DriveLetter = 'Z' Ensure = "Absent" } WaitforDisk DataDisk { DependsOn = "[OpticalDiskDriveLetter]MoveOpticalDrive" DiskId = $DataDiskLUN RetryIntervalSec = 60 RetryCount = 60 } Disk DataVolume { DiskId = $DataDiskLUN DriveLetter = $InstallationDrive FSLabel = 'NFV' DependsOn = '[WaitForDisk]DataDisk' } }Suggested solution
Remove filter for caption Microsoft Virtual DVD-ROM from DSC for Gen2 OS images.
Operating system the target node is running
PowerShell version and build the target node is running
StorageDsc version
The text was updated successfully, but these errors were encountered: