Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query parameters in play-spoken-text return entire text when empty string is passed #273

Open
hsluytergaethje opened this issue Nov 18, 2024 · 1 comment

Comments

@hsluytergaethje
Copy link

When the query parameters (gender, role, relations) in the endpoint /corpora/{corpusname}/plays/{playname}/spoken-text are set to empty string, the entire text is returned just as if the parameter is not set at all. This behaviour seems quite implicit.
Maybe it would be good to differentiate between the parameter not being passed at all and being passed with empty string as value?
Or it be documented that the two cases produce the same result.

@cmil
Copy link
Member

cmil commented Dec 20, 2024

I think it is pretty common behaviour that when you specify query parameters like this ?foo=&bar=, the processing application should treat the parameters foo and bar as if they where not set. What other behaviour would you expect? And how would it differ from omitting the query altogether?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants