Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relations-csv returns 404 for both play not found and relations not present #272

Open
hsluytergaethje opened this issue Nov 18, 2024 · 1 comment

Comments

@hsluytergaethje
Copy link

The endpoint /corpora/{corpusname}/plays/{playname}/relations/csv returns 404 when the play is not found as well as when no relations exist. Would it be possible to make the error more specific?

@cmil
Copy link
Member

cmil commented Dec 20, 2024

Maybe it would be less ambiguous to return 404 only when the play does not exist, but return kind of empty documents when the play is missing relation. That would mean for the CSV we would only return the header line, and for the XML formats an XML document without any node and edge elements. What do you think @lehkost and @ingoboerner.

@cmil cmil modified the milestone: 1.1.0 Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants