From 1a7eb3ec75731bdea16b8607c3588d2b05deb933 Mon Sep 17 00:00:00 2001 From: Radoslaw Kowalewski Date: Sat, 14 Dec 2024 13:45:20 +0100 Subject: [PATCH] Fix test failing on Windows Removed checking PHP_OS_FAMILY in favor of using is_link on symlinked directory. --- tests/Finder/RecursiveRegexFinderTest.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/Finder/RecursiveRegexFinderTest.php b/tests/Finder/RecursiveRegexFinderTest.php index 371630953..aa69ba64b 100644 --- a/tests/Finder/RecursiveRegexFinderTest.php +++ b/tests/Finder/RecursiveRegexFinderTest.php @@ -9,10 +9,9 @@ use function count; use function in_array; +use function is_link; use function sort; -use const PHP_OS_FAMILY; - class RecursiveRegexFinderTest extends FinderTestCase { public function testBadFilenameCausesErrorWhenFindingMigrations(): void @@ -43,11 +42,12 @@ public function testFindMigrationsReturnsTheExpectedFilesFromDirectory(): void 'TestMigrations\\DifferentNamingSchema', ]; - if (PHP_OS_FAMILY !== 'Windows') { + // Some Windows installations may not support symlinks + if (is_link(__DIR__ . '/_files/_symlinked_files')) { $tests[] = 'TestMigrations\\Version1SymlinkedFile'; } - self::assertCount(count($tests), $migrations); // Windows does not support symlinks + self::assertCount(count($tests), $migrations); foreach ($tests as $fqcn) { self::assertTrue(in_array($fqcn, $migrations, true)); }