Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional environment variables from secret #109

Open
virtualdxs opened this issue May 4, 2024 · 4 comments
Open

Support additional environment variables from secret #109

virtualdxs opened this issue May 4, 2024 · 4 comments

Comments

@virtualdxs
Copy link

virtualdxs commented May 4, 2024

I don't want environment variables like RELAY_PASSWORD to be in my git repository, so I'd like to be able to configure a Secret where I can specify arbitrary environment variables to be added to the container via envFrom.

@cfis
Copy link
Collaborator

cfis commented May 4, 2024

Sounds like a good idea to me - what to create a PR?

@virtualdxs
Copy link
Author

Unfortunately, I'm not sure what the best way to do that would be, as after diving into it further I noticed that every environment variable is already specified in env and so envFrom would not be able to override it. I ended up manually configuring all the resources per the documentation instead of using this helm chart.

@cfis
Copy link
Collaborator

cfis commented May 5, 2024

Yeah, probably should create a config map and secret and remove the envs from the deployment.

@emouawad
Copy link

+1 this is important for secret credentials like RELAY_PASSWORD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants