You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR7 has introduced the approle authentication method, which is good. Unfortunately unit tests are missing and the documentation is faulty.
The documentation of the class WebService::HashiCorp::Vault::Base states that client_id and secret are the approle configuration keys but the implementation uses role_id and secret_id instead. Furthermore I think something should be said about the precedence of the token attribute and the approle attribute, if both are passed to the constructor. This should not happen but the current implementation does not prevent that. In the end what we need is proper constructor overloading that is a challenge (impossible?) in perl.
The text was updated successfully, but these errors were encountered:
The correct behaviour is to reject both token and approle as you say. I would welcome a PR that enforced that behaviour and more unit tests are always welcome too.
PR7 has introduced the approle authentication method, which is good. Unfortunately unit tests are missing and the documentation is faulty.
The documentation of the class WebService::HashiCorp::Vault::Base states that client_id and secret are the approle configuration keys but the implementation uses role_id and secret_id instead. Furthermore I think something should be said about the precedence of the token attribute and the approle attribute, if both are passed to the constructor. This should not happen but the current implementation does not prevent that. In the end what we need is proper constructor overloading that is a challenge (impossible?) in perl.
The text was updated successfully, but these errors were encountered: