Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[documentation] wrong approle configuration keys #10

Open
XSven opened this issue Jun 21, 2021 · 2 comments
Open

[documentation] wrong approle configuration keys #10

XSven opened this issue Jun 21, 2021 · 2 comments

Comments

@XSven
Copy link

XSven commented Jun 21, 2021

PR7 has introduced the approle authentication method, which is good. Unfortunately unit tests are missing and the documentation is faulty.

The documentation of the class WebService::HashiCorp::Vault::Base states that client_id and secret are the approle configuration keys but the implementation uses role_id and secret_id instead. Furthermore I think something should be said about the precedence of the token attribute and the approle attribute, if both are passed to the constructor. This should not happen but the current implementation does not prevent that. In the end what we need is proper constructor overloading that is a challenge (impossible?) in perl.

@djzort
Copy link
Owner

djzort commented Jan 13, 2023

i have corrected the pod in cc118f0

@djzort
Copy link
Owner

djzort commented Jan 13, 2023

The correct behaviour is to reject both token and approle as you say. I would welcome a PR that enforced that behaviour and more unit tests are always welcome too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants