From 665515fcaef186a04b45f1c8f2173e8c4b8b04c8 Mon Sep 17 00:00:00 2001
From: "tianhaoyun@didiglobal.com" <tianhaoyun@didiglobal.com>
Date: Wed, 15 Jan 2025 16:54:32 +0800
Subject: [PATCH] =?UTF-8?q?perf:=20=E4=BB=A3=E7=A0=81=E4=BC=98=E5=8C=96?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 example/common/config.ts                      |  6 ++---
 example/pages/rate/index.mpx                  | 11 +++++---
 jest.config.js                                |  3 +--
 package.json                                  |  2 +-
 .../src/components/loading/index.mpx          |  2 +-
 .../src/components/loading/index.ts           |  2 +-
 .../mpx-cube-ui/src/components/rate/index.mpx |  2 +-
 .../mpx-cube-ui/src/components/rate/index.ts  | 27 ++++++-------------
 .../src/components/rate/rate-item-index.ts    |  4 ---
 .../src/components/switch/index.ts            |  4 +--
 pnpm-lock.yaml                                |  2 +-
 11 files changed, 25 insertions(+), 40 deletions(-)

diff --git a/example/common/config.ts b/example/common/config.ts
index 7741906..3e96aa0 100644
--- a/example/common/config.ts
+++ b/example/common/config.ts
@@ -41,8 +41,6 @@ export default {
           'icon',
           'divider',
           'float-ball',
-          'rate',
-          'switch',
           'loading'
         ]
       },
@@ -57,7 +55,9 @@ export default {
           'picker',
           'cascade-picker',
           'date-picker',
-          'time-picker'
+          'time-picker',
+          'rate',
+          'switch'
         ]
       },
       {
diff --git a/example/pages/rate/index.mpx b/example/pages/rate/index.mpx
index e2a8fd0..c7ff8ed 100644
--- a/example/pages/rate/index.mpx
+++ b/example/pages/rate/index.mpx
@@ -58,7 +58,7 @@
           </view>
         </view>
         <cube-toast
-          txt="为方便展示，示例中星星数最多为10～"
+          txt="为方便展示，示例中星星数最多为9～"
           wx:ref="toast">
         </cube-toast>
       </view>
@@ -71,7 +71,7 @@
 
   createPage({
     data: {
-      value: 4.5,
+      value: 3.3,
       max: '5',
       customize: false,
       justify: false,
@@ -92,9 +92,9 @@
       updateMaxLength (e) {
         const { value } = e.detail
         this.max = value
-        if (value >= 10) {
+        if (value > 9) {
           this.$refs.toast.show()
-          this.max = '10'
+          this.max = '9'
         }
       },
       updateJustify (e) {
@@ -156,6 +156,9 @@
 .cube-rate-item_active
   .rate-item-demo
     background-color: orange
+.cube-rate-item_half_active
+  .rate-item-demo
+    background-color: blue
 </style>
 
 <script type="application/json">
diff --git a/jest.config.js b/jest.config.js
index 66db89b..94ca7af 100644
--- a/jest.config.js
+++ b/jest.config.js
@@ -7,8 +7,7 @@ module.exports = {
   testEnvironment: 'jsdom',
   collectCoverage: false,
   testMatch: [
-    // '**/__tests__/**/*.spec.js'
-    '**/__tests__/**/rate.spec.js'
+    '**/__tests__/**/*.spec.js'
   ],
   collectCoverageFrom: ['/packages/mpx-cube-ui/src/components/**/*.{js,mpx,ts}'],
   coverageDirectory: 'test/coverage',
diff --git a/package.json b/package.json
index 1219860..30dbbb3 100644
--- a/package.json
+++ b/package.json
@@ -17,7 +17,7 @@
     "docs:prod": "npm run example:build && NODE_ENV=production npm run docs:build && cp -r ./example/dist/web ./docs/.vuepress/dist/example",
     "example:build": "cd example && npm run build:web",
     "example:dev": "cd example && npm run watch:web",
-    "example:mp:dev": "cd example && npm run watch:ali",
+    "example:mp:dev": "cd example && npm run watch:mp",
     "fix": "eslint --fix --ext .js,.ts,.mpx packages/",
     "lint": "eslint --ext .js,.ts,.mpx packages/",
     "prepare": "husky install",
diff --git a/packages/mpx-cube-ui/src/components/loading/index.mpx b/packages/mpx-cube-ui/src/components/loading/index.mpx
index fa66501..bf355c6 100644
--- a/packages/mpx-cube-ui/src/components/loading/index.mpx
+++ b/packages/mpx-cube-ui/src/components/loading/index.mpx
@@ -1,7 +1,7 @@
 <template>
   <view class="cube-single-loading">
     <text class="cube-loading-spinners" wx:style="{{style}}">
-        <text class="cube-loading-spinner" wx:for="{{balde}}"></text>
+      <text class="cube-loading-spinner" wx:for="{{line}}"></text>
     </text>
   </view>
 </template>
diff --git a/packages/mpx-cube-ui/src/components/loading/index.ts b/packages/mpx-cube-ui/src/components/loading/index.ts
index 05b527a..8e5b511 100644
--- a/packages/mpx-cube-ui/src/components/loading/index.ts
+++ b/packages/mpx-cube-ui/src/components/loading/index.ts
@@ -8,7 +8,7 @@ createComponent({
     }
   },
   data: {
-    balde: 12
+    line: 12
   },
   computed: {
     style() {
diff --git a/packages/mpx-cube-ui/src/components/rate/index.mpx b/packages/mpx-cube-ui/src/components/rate/index.mpx
index 871ed2f..3614850 100644
--- a/packages/mpx-cube-ui/src/components/rate/index.mpx
+++ b/packages/mpx-cube-ui/src/components/rate/index.mpx
@@ -11,7 +11,7 @@
     <view class="cube-rate-items" id="cube-rate-items" wx:class="{{rateClass}}" >
       <slot wx:if="{{isCustomize}}"></slot>
       <block wx:else>
-        <rate-item wx:for="{{max}}" wx:key="item" index="{{item}}" value="{{value}}" isCustomize="{{false}}"/>
+        <rate-item wx:for="{{max}}" wx:key="item" index="{{item}}" value="{{value}}"/>
       </block>
     </view>
   </view>
diff --git a/packages/mpx-cube-ui/src/components/rate/index.ts b/packages/mpx-cube-ui/src/components/rate/index.ts
index c7ea672..f2b0ab8 100644
--- a/packages/mpx-cube-ui/src/components/rate/index.ts
+++ b/packages/mpx-cube-ui/src/components/rate/index.ts
@@ -100,33 +100,22 @@ createComponent({
     handleMove(e) {
       e.preventDefault && e.preventDefault()
       if (this.disabled) return
-
-      if (!isMouseEvent(e)) {
-        this.computeTempValue(e.touches[0])
-      } else if (this.mousePressed) {
-        this.computeTempValue(e)
-      }
+      this.computeTempValue(isMouseEvent(e) ? e : e.touches[0])
     },
     handleEnd(e) {
       if (this.disabled) return
-      if ((!isMouseEvent(e) || this.mousePressed)) {
-        if (isMouseEvent(e)) {
-          this.mousePressed = false
-          document.removeEventListener('mouseup', this.handleEnd)
-          document.removeEventListener('mousemove', this.handleMove)
-        }
-        this.computeTempValue(isMouseEvent(e) ? e : e.changedTouches[0])
-        this.triggerEvent(EVENT_INPUT, { value: this.tempValue })
+      if (isMouseEvent(e)) {
+        this.mousePressed = false
+        document.removeEventListener('mouseup', this.handleEnd)
+        document.removeEventListener('mousemove', this.handleMove)
       }
+      this.computeTempValue(isMouseEvent(e) ? e : e.changedTouches[0])
+      this.triggerEvent(EVENT_INPUT, { value: this.tempValue })
     },
     handleNum(num) {
       if (this.allowHalf) {
         const baseNum = Math.ceil(num) - 0.5
-        if (this.disabled) {
-          num = num < baseNum ? baseNum - 0.5 : baseNum
-        } else {
-          num = num <= baseNum ? baseNum : baseNum + 0.5
-        }
+        num = num <= baseNum ? baseNum : baseNum + 0.5
       } else {
         num = Math.ceil(num)
       }
diff --git a/packages/mpx-cube-ui/src/components/rate/rate-item-index.ts b/packages/mpx-cube-ui/src/components/rate/rate-item-index.ts
index b0f7ea3..d7687ba 100644
--- a/packages/mpx-cube-ui/src/components/rate/rate-item-index.ts
+++ b/packages/mpx-cube-ui/src/components/rate/rate-item-index.ts
@@ -10,10 +10,6 @@ createComponent({
     value: {
       type: Number,
       value: 0
-    },
-    isCustomize: {
-      type: Boolean,
-      value: true
     }
   },
   computed: {
diff --git a/packages/mpx-cube-ui/src/components/switch/index.ts b/packages/mpx-cube-ui/src/components/switch/index.ts
index 841e53b..e318855 100644
--- a/packages/mpx-cube-ui/src/components/switch/index.ts
+++ b/packages/mpx-cube-ui/src/components/switch/index.ts
@@ -17,9 +17,7 @@ createComponent({
   computed: {
     switchClass() {
       return {
-        'cube-switch': true,
-        'cube-switch-on': this.isOn,
-        [`cube-switch-${this.themeType}`]: this.themeType
+        'cube-switch-on': this.isOn
       }
     }
   },
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index 9dac4bf..70b34e6 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -213,7 +213,7 @@ importers:
         version: 1.9.10(lodash@4.17.21)(prettier@2.8.8)
     devDependencies:
       '@mpxjs/extract-theme-var':
-        specifier: workspace:1.0.3
+        specifier: workspace:1.0.2
         version: link:../extract-theme-var
       '@mpxjs/vuese-markdown-render':
         specifier: ^1.0.0