From a835ae14d502e1c8f730d2835742936ed1fce1c6 Mon Sep 17 00:00:00 2001
From: Birk Johansson <birk@dhis2.org>
Date: Tue, 30 Jan 2024 02:17:59 +0100
Subject: [PATCH] refactor: more cleanup

---
 .../sectionList/listView/ManageListView.tsx   | 90 +++++++++----------
 1 file changed, 43 insertions(+), 47 deletions(-)

diff --git a/src/components/sectionList/listView/ManageListView.tsx b/src/components/sectionList/listView/ManageListView.tsx
index ca13fd36..b0e97a3c 100644
--- a/src/components/sectionList/listView/ManageListView.tsx
+++ b/src/components/sectionList/listView/ManageListView.tsx
@@ -29,6 +29,7 @@ type FormValues = {
     columns: string[]
     filters: string[]
 }
+
 const validate = (values: FormValues) => {
     const errors: Record<string, string> = {}
 
@@ -91,53 +92,48 @@ export const ManageListView = ({
     }, [savedFilters, savedColumns, filtersConfig, columnsConfig])
 
     return (
-        <>
-            <Form
-                onSubmit={handleSave}
-                initialValues={initialValues}
-                validate={validate}
-            >
-                {({ handleSubmit, submitting, submitError }) => (
-                    <form onSubmit={handleSubmit}>
-                        <TransferField
-                            name={'columns'}
-                            availableLabel={i18n.t('Available columns')}
-                            selectedLabel={i18n.t('Selected columns')}
-                            loading={query.isLoading}
-                            defaultOptions={columnsConfig.default.map(toPath)}
-                            availableOptions={columnsConfig.available.map(
-                                (c) => ({ label: c.label, value: c.path })
-                            )}
-                        />
-                        <TransferField
-                            name={'filters'}
-                            availableLabel={i18n.t('Available filters')}
-                            selectedLabel={i18n.t('Selected filters')}
-                            loading={query.isLoading}
-                            defaultOptions={filtersConfig.default.map(
-                                toFilterKey
-                            )}
-                            availableOptions={filtersConfig.available.map(
-                                (f) => ({ label: f.label, value: f.filterKey })
-                            )}
-                        />
-                        {submitError && (
-                            <p>
-                                <NoticeBox
-                                    error
-                                    title={i18n.t('Failed to save')}
-                                >
-                                    {submitError}
-                                </NoticeBox>
-                            </p>
-                        )}
-                        {children({
-                            submitting,
-                        })}
-                    </form>
-                )}
-            </Form>
-        </>
+        <Form
+            onSubmit={handleSave}
+            initialValues={initialValues}
+            validate={validate}
+        >
+            {({ handleSubmit, submitting, submitError }) => (
+                <form onSubmit={handleSubmit}>
+                    <TransferField
+                        name={'columns'}
+                        availableLabel={i18n.t('Available columns')}
+                        selectedLabel={i18n.t('Selected columns')}
+                        loading={query.isLoading}
+                        defaultOptions={columnsConfig.default.map(toPath)}
+                        availableOptions={columnsConfig.available.map((c) => ({
+                            label: c.label,
+                            value: c.path,
+                        }))}
+                    />
+                    <TransferField
+                        name={'filters'}
+                        availableLabel={i18n.t('Available filters')}
+                        selectedLabel={i18n.t('Selected filters')}
+                        loading={query.isLoading}
+                        defaultOptions={filtersConfig.default.map(toFilterKey)}
+                        availableOptions={filtersConfig.available.map((f) => ({
+                            label: f.label,
+                            value: f.filterKey,
+                        }))}
+                    />
+                    {submitError && (
+                        <p>
+                            <NoticeBox error title={i18n.t('Failed to save')}>
+                                {submitError}
+                            </NoticeBox>
+                        </p>
+                    )}
+                    {children({
+                        submitting,
+                    })}
+                </form>
+            )}
+        </Form>
     )
 }