diff --git a/dhis-2/dhis-test-web-api/src/test/java/org/hisp/dhis/webapi/controller/dataintegrity/DataIntegrityUsersWithInvalidUsernameControllerTest.java b/dhis-2/dhis-test-web-api/src/test/java/org/hisp/dhis/webapi/controller/dataintegrity/DataIntegrityUsersWithInvalidUsernameControllerTest.java index 907a2068c9e9..95ab01c51c24 100644 --- a/dhis-2/dhis-test-web-api/src/test/java/org/hisp/dhis/webapi/controller/dataintegrity/DataIntegrityUsersWithInvalidUsernameControllerTest.java +++ b/dhis-2/dhis-test-web-api/src/test/java/org/hisp/dhis/webapi/controller/dataintegrity/DataIntegrityUsersWithInvalidUsernameControllerTest.java @@ -38,7 +38,6 @@ import org.hisp.dhis.test.webapi.json.domain.JsonDataIntegrityDetails; import org.hisp.dhis.test.webapi.json.domain.JsonDataIntegritySummary; import org.hisp.dhis.user.User; -import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Test; /** @@ -54,7 +53,6 @@ class DataIntegrityUsersWithInvalidUsernameControllerTest private static final String DETAILS_ID_TYPE = "users"; - @Disabled("TODO(Jason P. Pickering)") @Test void testCanFlagUsersWithInvalidUsername() { @@ -84,10 +82,10 @@ void testCanFlagUsersWithInvalidUsername() { assertEquals(DETAILS_ID_TYPE, details.getIssuesIdType()); assertEquals(CHECK_NAME, details.getName()); - // There are already two existing users as part of the test setup, thus 5/7 users have bad + // There is already an existing user as part of the test setup, thus 5/6 users have bad // usernames JsonDataIntegritySummary summary = getSummary(CHECK_NAME); - assertTrue(almostEqual(71.4, summary.getPercentage().doubleValue(), 0.1)); + assertTrue(almostEqual(83.3, summary.getPercentage().doubleValue(), 0.1)); assertEquals(badUsernames.size(), summary.getCount()); } diff --git a/dhis-2/dhis-test-web-api/src/test/java/org/hisp/dhis/webapi/controller/dataintegrity/DataIntegrityUsersWithNoRoleControllerTest.java b/dhis-2/dhis-test-web-api/src/test/java/org/hisp/dhis/webapi/controller/dataintegrity/DataIntegrityUsersWithNoRoleControllerTest.java index 310945cbba32..fc38fe9490ca 100644 --- a/dhis-2/dhis-test-web-api/src/test/java/org/hisp/dhis/webapi/controller/dataintegrity/DataIntegrityUsersWithNoRoleControllerTest.java +++ b/dhis-2/dhis-test-web-api/src/test/java/org/hisp/dhis/webapi/controller/dataintegrity/DataIntegrityUsersWithNoRoleControllerTest.java @@ -34,7 +34,6 @@ import org.hisp.dhis.jsontree.JsonList; import org.hisp.dhis.test.webapi.json.domain.JsonDataIntegrityDetails; import org.hisp.dhis.user.User; -import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Test; /** @@ -49,7 +48,6 @@ class DataIntegrityUsersWithNoRoleControllerTest extends AbstractDataIntegrityIn private static final String DETAILS_ID_TYPE = "users"; - @Disabled("TODO(Jason P. Pickering)") @Test void testCanFlagUserWithNoRoles() { @@ -65,10 +63,10 @@ void testCanFlagUserWithNoRoles() { manager.persist(user); dbmsManager.clearSession(); - // Note that there are already two users which exist due to the overall test setup, thus, three + // Note that there is already one user which exists due to the overall test setup, thus, two // users in total. assertHasDataIntegrityIssues( - DETAILS_ID_TYPE, CHECK_NAME, 33, user.getUid(), user.getUsername(), "disabled:false", true); + DETAILS_ID_TYPE, CHECK_NAME, 50, user.getUid(), user.getUsername(), "disabled:false", true); JsonDataIntegrityDetails details = getDetails(CHECK_NAME); JsonList issues = details.getIssues();