Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove @aspect_rules_jasmine from user workspaces #55

Open
dgp1130 opened this issue Feb 14, 2023 · 0 comments
Open

Remove @aspect_rules_jasmine from user workspaces #55

dgp1130 opened this issue Feb 14, 2023 · 0 comments
Labels
cleanup Internal cleanup of infrastructure

Comments

@dgp1130
Copy link
Owner

dgp1130 commented Feb 14, 2023

Currently we have to include @aspect_rules_jasmine for all @rules_prerender users because the build rules are referenced, even if the targets are never built. This is an unnecessary dependency and should be removed by refactoring the BUILD rules to not require it.

rules_prerender/repositories.bzl

Lines 22 to 23 in 975929f

if "jasmine" not in native.existing_rules():
jasmine_repositories(name = "jasmine")

@dgp1130 dgp1130 added the cleanup Internal cleanup of infrastructure label Feb 14, 2023
@dgp1130 dgp1130 mentioned this issue Feb 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Internal cleanup of infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dgp1130