Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide web_resources_devserver() internal flags #54

Open
dgp1130 opened this issue Feb 5, 2023 · 0 comments
Open

Hide web_resources_devserver() internal flags #54

dgp1130 opened this issue Feb 5, 2023 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@dgp1130
Copy link
Owner

dgp1130 commented Feb 5, 2023

Currently, the only flag which web_resources_devserver() supports is --port, but anything you pass gets propagated through to the underlying http-server, meaning all it's flags are accessible. This leaks the abstraction and makes it harder to change the implementation over time.

web_resources_devserver() should explicitly ban any other arguments to make this a stronger abstraction.

@dgp1130 dgp1130 added the bug Something isn't working label Feb 5, 2023
@dgp1130 dgp1130 added this to the 1.0.0 milestone Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant