From e0bc13498530fab6695a6540701bcafc3cac37a4 Mon Sep 17 00:00:00 2001 From: Doug Parker Date: Sun, 12 Mar 2023 18:26:16 -0700 Subject: [PATCH] Makes `//:node_modules/@rules_prerender/declarative_shadow_dom` private. Refs #71. I accidentally used this target today when I actually wanted `//:prerender_components/@rules_prerender/declarative_shadow_dom`. There is not much use for the Node module and using it directly violates the expectation that all the various "slices" of the component stay together in a cohesive way. Limiting visibility makes it easier to catch this mistake in the future. --- BUILD.bazel | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/BUILD.bazel b/BUILD.bazel index cf1f33bd..449e4ee1 100644 --- a/BUILD.bazel +++ b/BUILD.bazel @@ -61,7 +61,8 @@ types_only( npm_link_package( name = "node_modules/@rules_prerender/declarative_shadow_dom", src = "//packages/declarative_shadow_dom:pkg", - visibility = ["//:__subpackages__"], + # Should use `//:prerender_components/@rules_prerender/declarative_shadow_dom`. + visibility = ["//visibility:private"], ) link_prerender_component( name = "prerender_components/@rules_prerender/declarative_shadow_dom",