Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile embedded git with USE_LIBPCRE #160

Closed
ovy opened this issue Jan 18, 2018 · 2 comments
Closed

Compile embedded git with USE_LIBPCRE #160

ovy opened this issue Jan 18, 2018 · 2 comments

Comments

@ovy
Copy link

ovy commented Jan 18, 2018

I use a commit hook that does git grep -P, i.e. uses Perl regexps which is a compile time dependency. This works everywhere but Atom's git support, where it fails because that git is built without it.

It seems that just about everyone else compiles with pcre. Short list of git versions we use where this works:

  • Linux and Homebrew distributions
  • Github Desktop on Mac and Windows
  • Recent Apple versions (Apple Git-98). The system (xcode) git used to not have PCRE a while back (when it was an ancient 1.8.something) but it does as of High Sierra.
  • Official git-scm.org package for Mac

Having an embedded git, while convenient, should follow mainstream git as closely as possible in my opinion. And PCRE in turn is probably the "mainstream RE" these days and not some esoteric option.

I've taken to telling people who use Atom to simply remove the dugite git-core, forcing it to use system, but this seems sub-optimal if you guys are relying on the behaviors of a fixed version. Eliminating the grep -P is non-trivial.

@shiftkey
Copy link
Member

@ovy can you re-file this over on https://github.com/desktop/dugite-native which is the actual Git toolchain? This behaviour is due to compiling Git with NO_PERL enable to avoid the dependency, and we can talk more about that over there.

@ovy
Copy link
Author

ovy commented Jan 18, 2018

Thanks @shiftkey -- opened desktop/dugite-native#74 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants