-
Notifications
You must be signed in to change notification settings - Fork 13
504 constant timeouts? #28
Comments
Thanks for reporting the issue. Have you tried running the example project in this repo? Curious to know if that works for you. You might also try installing ember-prerender from Github instead of NPM as NPM is a few commits behind (use: What version of Ember are you running? I would make sure the XContentReady event is firing and maybe setup a very minimal route to test with. As far as I know, ember-prerender shouldn't ever be sending a 504. It sends a 503 on timeout and 500 in the case of a fatal JS error. I do need to revisit JSDOM, I was having some problems with Ember 1.8 and beyond, not sure what the issue is yet. You could try running it with the webdriver option as an additional way to try pinpointing the issue. |
Thanks for the help! I can say it's definitely giving a 504 error (which makes sense for timeout, since that's a Gateway Timeout error) though I can't find anywhere in the source which is giving a 504. Anyways, it looks like XContentReady is indeed never being fired. In fact, the I've made some improvements to the Ember-side hooks, namely using For reference, my Ember.Route.reopen({
willComplete: function() {
return Ember.RSVP.resolve();
},
actions: {
didTransition: function() {
console.log('transitioning');
this._super();
let promises = [];
this.router.router.currentHandlerInfos.forEach((handler) => {
if (handler.handler.willComplete) {
promises.push(handler.handler.willComplete());
}
});
Ember.RSVP.all(promises).then(() => document.dispatchEvent(window.XContentReadyEvent));
}
}
}); the Edit: could it be that the action is being overridden by route subclasses? Wouldn't |
Fixed all that, confirmed that it's emitting the events now (the I tried my cluster'd version (linked in OP) with the example app and got the following error:
(no, that's not truncated, it really ends at "for", I think because I'm getting I would say "maybe it's not threadsafe" except Node isn't threading it, it's forking multiple processes. Color me doublestumped. |
I'm trying to use this to prerender hummingbird.me but I've run into two problems: (1) it gives a 504 error on all endpoints (which it seems to attempt to continue using that worker too) and I can't seem to get it to be more verbose and help me understand the problem and (2) it refuses to switch to JSDOM so I can debug it better (since I understand jsdom better than phantomjs)
I'm not sure if this might be related to my
cluster
ing it to increase rendering thoroughput. Any help would be appreciated, I took a look but didn't find anything obviously wrong.I'd really prefer to use this over something like prerender.io because (a) it's open-source completely and (b) it's deterministic, and I have a hatred of nondeterministic systems from my user scripting days 😉
The text was updated successfully, but these errors were encountered: