Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an Error on Python 3.9 or Lower AND Update README for 2.x Support #292

Open
davidvonthenen opened this issue Feb 8, 2024 · 0 comments
Labels
low priority Do these last...
Milestone

Comments

@davidvonthenen
Copy link
Contributor

davidvonthenen commented Feb 8, 2024

What is the current behavior?

When installing on a system using Python version 3.9 or lower, the install mechanism should error out.

There was an attempt to try an do this, but apparently it didn't work out:
https://github.com/deepgram/deepgram-python-sdk/blob/main/setup.py#L9-L10

We should also update the docs so that we 3.9 and older versions can still use 2.x SDK as is. We will support security bug fixes as needed.

Steps to reproduce

Able to install on 3.9 or lower.

Expected behavior

Throw an error on install.

Please tell us about your environment

Other information

NA

@davidvonthenen davidvonthenen changed the title Doesn't Throw an Install Error on Python 3.9 or Lower Throw an Error on Python 3.9 or Lower AND Update README for 2.x Support Mar 18, 2024
@davidvonthenen davidvonthenen added this to the Python SDK v.3.3 milestone Apr 17, 2024
@davidvonthenen davidvonthenen added the low priority Do these last... label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority Do these last...
Projects
None yet
Development

No branches or pull requests

1 participant