FreeBSD CI!

[mobin-2008]

Hello.
During this time, I was working on the CI of the Dinit project. Currently the major weakness of CI is the lack of infrastructure to test Dinit on a BSD. I was trying to run FreeBSD on Github CI with virtualization and it failed. Github CI blocks any virtualization.
I noticed a project called Cirrus-CI. This project provides a FreeBSD infrastructure for CI and also allows projects published publicly on Github to use this service for free.
I am working on it now (on https://github.com/mobin-2008/dinit). A question has occupied my mind:
I unfortunately couldn't find a way to use the FreeBSD package manager (pkg) in the script. I mean, apt-get with the -y switch allows no need to manually confirm the operation. I did not find similar functionality in pkg.

[mobin-2008]

Thats fixed with env variable: ASSUME_ALWAYS_YES=YES
https://forums.freebsd.org/threads/pkg-unattended-install.36183/post-504034

[mobin-2008]

We have a problem!
Maybe its a typo in MakeFile.
@davmac314 Please check this out: https://cirrus-ci.com/task/5475137897103360?logs=Build#L11
Log:

make
*** Found configuration for OS: FreeBSD
make -C build all
make -C tools mconfig-gen
clang++ -std=c++11 -Os -Wall -fno-plt -fno-rtti -o mconfig-gen mconfig-gen.cc -lrt
./tools/mconfig-gen SBINDIR=/sbin SYSCONTROLSOCKET=/var/run/dinitctl  SHUTDOWN_PREFIX= VERSION=0.16.0pre     > includes/mconfig.h
make -C src all
make[1]: "/tmp/cirrus-ci-build/src/Makefile" line 6: Invalid line type
make[1]: "/tmp/cirrus-ci-build/src/Makefile" line 8: Invalid line type
make[1]: "/tmp/cirrus-ci-build/src/Makefile" line 53: Invalid line type
make[1]: "/tmp/cirrus-ci-build/src/Makefile" line 57: Invalid line type
make[1]: Fatal errors encountered -- cannot continue
make[1]: stopped in /tmp/cirrus-ci-build/src
*** Error code 1

Stop.
make: stopped in /tmp/cirrus-ci-build

[mobin-2008]

@davmac314 log with -std=c++14:

gmake
*** Found configuration for OS: FreeBSD
gmake -C build all
gmake[1]: Entering directory '/tmp/cirrus-ci-build/build'
gmake -C tools mconfig-gen
gmake[2]: Entering directory '/tmp/cirrus-ci-build/build/tools'
clang++ -std=c++14 -Os -Wall -fno-plt -fno-rtti -o mconfig-gen mconfig-gen.cc -lrt
gmake[2]: Leaving directory '/tmp/cirrus-ci-build/build/tools'
./tools/mconfig-gen SBINDIR=/sbin SYSCONTROLSOCKET=/var/run/dinitctl \
	 \
gmake[1]: Leaving directory '/tmp/cirrus-ci-build/build'
gmake[1]: Entering directory '/tmp/cirrus-ci-build/src'
clang++ -std=c++14 -Os -Wall -fno-plt -fno-rtti -MMD -MP -Iincludes -I../dasynq/include -I../build/includes -c dinit.cc -o dinit.o
In file included from dinit.cc:29:
In file included from includes/service.h:17:
In file included from includes/load-service.h:19:
includes/dinit-util.h:275:49: error: field of type 'dinit_unordered_set<std::string, hash_env_name, env_equal_name>::iterator::list_iterator_t' (aka '__list_iterator<std::string, void *>') has private constructor
        iterator() noexcept : buckets(nullptr), list_it({}), bucket_num(-1) { }
                                                ^
includes/dinit-util.h:476:32: note: in instantiation of function template specialization 'dinit_unordered_set<std::string, hash_env_name, env_equal_name>::find<string_view>' requested here
        return non_const_this->find(value);
                               ^
includes/dinit-env.h:103:28: note: In file included from dinit.cc:29:
In file included from includes/service.h:17:
In file included from includes/load-service.h:19:
includes/dinit-util.h:275:49: error: field of type 'dinit_unordered_set<std::string, hash_sv, dinit_equal_to>::iterator::list_iterator_t' (aka '__list_iterator<std::string, void *>') has private constructor
        iterator() noexcept : buckets(nullptr), list_it({}), bucket_num(-1) { }
                                                ^
includes/dinit-util.h:385:16: note: in instantiation of member function 'dinit_unordered_set<std::string, hash_sv, dinit_equal_to>::iterator::iterator' requested here
    explicit __list_iterator(__link_pointer __p) _NOEXCEPT : __ptr_(__p) {}
             ^
2 errors generated.
gmake[1]: *** [Makefile:39: dinit.o] Error 1
gmake[1]: Leaving directory '/tmp/cirrus-ci-build/src'
Exit status: 2

[davmac314]

Should be fixed now (and should not require -std=c++14!).

[mobin-2008]

@davmac314 Dinit compiles correctly but fails in "Unit tests". Please check this out: https://cirrus-ci.com/task/6641877993652224?logs=Unit%20tests#L17

[mobin-2008]

@davmac314 Dinit compiles correctly but fails in "Unit tests". Please check this out: https://cirrus-ci.com/task/6641877993652224?logs=Unit%20tests#L17

gmake check

gmake -C src check

gmake[1]: Entering directory '/tmp/cirrus-ci-build/src'

gmake -C tests check

gmake[2]: Entering directory '/tmp/cirrus-ci-build/src/tests'

mkdir -p includes

rm -rf includes/*.h

cd includes; ln -f ../../includes/*.h .

cd includes; ln -f ../test-includes/*.h .

clang++ -std=c++11 -Os -Wall -fno-plt -fno-rtti -fsanitize=address,undefined -MMD -MP -Iincludes -I../../dasynq/include -I../../build/includes -c ../service.cc -o service.o

clang++ -std=c++11 -Os -Wall -fno-plt -fno-rtti -fsanitize=address,undefined -MMD -MP -Iincludes -I../../dasynq/include -I../../build/includes -c ../proc-service.cc -o proc-service.o

clang++ -std=c++11 -Os -Wall -fno-plt -fno-rtti -fsanitize=address,undefined -MMD -MP -Iincludes -I../../dasynq/include -I../../build/includes -c ../dinit-log.cc -o dinit-log.o

../dinit-log.cc:70:11: warning: 'fd_event' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]

rearm fd_event(eventloop_t &loop, int fd, int flags) noexcept;

^

includes/dinit.h:125:23: note: overridden virtual function is here

virtual rearm fd_event(eventloop_t & loop, int fd, int flags) = 0;

^

1 warning generated.

clang++ -std=c++11 -Os -Wall -fno-plt -fno-rtti -fsanitize=address,undefined -MMD -MP -Iincludes -I../../dasynq/include -I../../build/includes -c ../load-service.cc -o load-service.o

clang++ -std=c++11 -Os -Wall -fno-plt -fno-rtti -fsanitize=address,undefined -MMD -MP -Iincludes -I../../dasynq/include -I../../build/includes -c ../baseproc-service.cc -o baseproc-service.o

clang++ -std=c++11 -Os -Wall -fno-plt -fno-rtti -fsanitize=address,undefined -MMD -MP -Iincludes -I../../dasynq/include -I../../build/includes -c ../dinit-env.cc -o dinit-env.o

clang++ -std=c++11 -Os -Wall -fno-plt -fno-rtti -fsanitize=address,undefined -MMD -MP -Iincludes -I../../dasynq/include -I../../build/includes -c tests.cc -o tests.o

clang++ -std=c++11 -Os -Wall -fno-plt -fno-rtti -fsanitize=address,undefined -MMD -MP -Iincludes -I../../dasynq/include -I../../build/includes -c test-dinit.cc -o test-dinit.o

clang++ -std=c++11 -Os -Wall -fno-plt -fno-rtti -fsanitize=address,undefined -MMD -MP -Iincludes -I../../dasynq/include -I../../build/includes -c test-bpsys.cc -o test-bpsys.o

clang++ -std=c++11 -Os -Wall -fno-plt -fno-rtti -fsanitize=address,undefined -MMD -MP -Iincludes -I../../dasynq/include -I../../build/includes -c test-run-child-proc.cc -o test-run-child-proc.o

clang++ -fsanitize=address,undefined -o tests service.o proc-service.o dinit-log.o load-service.o baseproc-service.o dinit-env.o tests.o test-dinit.o test-bpsys.o test-run-child-proc.o -std=c++11 -Os -Wall -fno-plt -fno-rtti -lrt

clang++ -std=c++11 -Os -Wall -fno-plt -fno-rtti -fsanitize=address,undefined -MMD -MP -Iincludes -I../../dasynq/include -I../../build/includes -c proctests.cc -o proctests.o

clang++ -fsanitize=address,undefined -o proctests service.o proc-service.o dinit-log.o load-service.o baseproc-service.o dinit-env.o proctests.o test-dinit.o test-bpsys.o test-run-child-proc.o -std=c++11 -Os -Wall -fno-plt -fno-rtti -lrt

clang++ -std=c++11 -Os -Wall -fno-plt -fno-rtti -fsanitize=address,undefined -MMD -MP -Iincludes -I../../dasynq/include -I../../build/includes -c loadtests.cc -o loadtests.o

clang++ -fsanitize=address,undefined -o loadtests service.o proc-service.o dinit-log.o load-service.o baseproc-service.o dinit-env.o loadtests.o test-dinit.o test-bpsys.o test-run-child-proc.o -std=c++11 -Os -Wall -fno-plt -fno-rtti -lrt

clang++ -std=c++11 -Os -Wall -fno-plt -fno-rtti -fsanitize=address,undefined -MMD -MP -Iincludes -I../../dasynq/include -I../../build/includes -c envtests.cc -o envtests.o

clang++ -fsanitize=address,undefined -o envtests service.o proc-service.o dinit-log.o load-service.o baseproc-service.o dinit-env.o envtests.o test-dinit.o test-bpsys.o test-run-child-proc.o -std=c++11 -Os -Wall -fno-plt -fno-rtti -lrt

gmake -C cptests build-tests

gmake[3]: Entering directory '/tmp/cirrus-ci-build/src/tests/cptests'

mkdir -p includes

rm -rf includes/*.h

cd includes; ln -f ../../../includes/*.h .

cd includes; ln -f ../../test-includes/dinit.h .

cd includes; ln -f ../../test-includes/baseproc-sys.h .

clang++ -std=c++11 -Os -Wall -fno-plt -fno-rtti -fsanitize=address,undefined -MMD -MP -Iincludes -I../../../dasynq/include -I../../../build/includes -c cptests.cc -o cptests.o

clang++ -std=c++11 -Os -Wall -fno-plt -fno-rtti -fsanitize=address,undefined -MMD -MP -Iincludes -I../../../dasynq/include -I../../../build/includes -c ../../control.cc -o control.o

clang++ -std=c++11 -Os -Wall -fno-plt -fno-rtti -fsanitize=address,undefined -MMD -MP -Iincludes -I../../../dasynq/include -I../../../build/includes -c ../../dinit-log.cc -o dinit-log.o

../../dinit-log.cc:70:11: warning: 'fd_event' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]

rearm fd_event(eventloop_t &loop, int fd, int flags) noexcept;

^

includes/dinit.h:125:23: note: overridden virtual function is here

virtual rearm fd_event(eventloop_t & loop, int fd, int flags) = 0;

^

1 warning generated.

clang++ -std=c++11 -Os -Wall -fno-plt -fno-rtti -fsanitize=address,undefined -MMD -MP -Iincludes -I../../../dasynq/include -I../../../build/includes -c ../../service.cc -o service.o

clang++ -std=c++11 -Os -Wall -fno-plt -fno-rtti -fsanitize=address,undefined -MMD -MP -Iincludes -I../../../dasynq/include -I../../../build/includes -c ../../load-service.cc -o load-service.o

clang++ -std=c++11 -Os -Wall -fno-plt -fno-rtti -fsanitize=address,undefined -MMD -MP -Iincludes -I../../../dasynq/include -I../../../build/includes -c ../../proc-service.cc -o proc-service.o

clang++ -std=c++11 -Os -Wall -fno-plt -fno-rtti -fsanitize=address,undefined -MMD -MP -Iincludes -I../../../dasynq/include -I../../../build/includes -c ../../baseproc-service.cc -o baseproc-service.o

clang++ -std=c++11 -Os -Wall -fno-plt -fno-rtti -fsanitize=address,undefined -MMD -MP -Iincludes -I../../../dasynq/include -I../../../build/includes -c ../../run-child-proc.cc -o run-child-proc.o

../../run-child-proc.cc:337:5: error: use of undeclared identifier 'environ'; did you mean 'bp_sys::environ'?

environ = const_cast<char **>(proc_env_map.env_list.data());

^~~~~~~

bp_sys::environ

includes/baseproc-sys.h:140:15: note: 'bp_sys::environ' declared here

extern char **environ;

^

1 error generated.

gmake[3]: *** [Makefile:29: run-child-proc.o] Error 1

gmake[3]: Leaving directory '/tmp/cirrus-ci-build/src/tests/cptests'

gmake[2]: *** [Makefile:9: build-tests] Error 2

gmake[2]: Leaving directory '/tmp/cirrus-ci-build/src/tests'

gmake[1]: *** [Makefile:42: check] Error 2

gmake[1]: Leaving directory '/tmp/cirrus-ci-build/src'

gmake: *** [Makefile:13: check] Error 2

Exit status: 2

[davmac314]

Should be fine now. Passes "make && make check" in a FreeBSD VM that I'm running.