From c11944de7860319925e3606f9bc5530a7d4c97ea Mon Sep 17 00:00:00 2001
From: Ivan Shumkov <ivan@shumkov.ru>
Date: Mon, 30 Oct 2023 18:19:36 +0700
Subject: [PATCH] chore: remove $ form consensus error messages

---
 .../identity/duplicated_identity_public_key_basic_error.rs      | 2 +-
 .../identity/duplicated_identity_public_key_id_basic_error.rs   | 2 +-
 ...ity_asset_lock_transaction_out_point_already_exists_error.rs | 2 +-
 .../identity_asset_lock_transaction_output_not_found_error.rs   | 2 +-
 .../invalid_asset_lock_transaction_output_return_size.rs        | 2 +-
 .../identity/invalid_identity_asset_lock_transaction_error.rs   | 2 +-
 .../invalid_identity_asset_lock_transaction_output_error.rs     | 2 +-
 .../basic/identity/invalid_instant_asset_lock_proof_error.rs    | 2 +-
 .../consensus/state/identity/identity_already_exists_error.rs   | 2 +-
 .../state/identity/identity_insufficient_balance_error.rs       | 2 +-
 ...ublic_key_already_exists_for_unique_contract_bounds_error.rs | 2 +-
 11 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/packages/rs-dpp/src/errors/consensus/basic/identity/duplicated_identity_public_key_basic_error.rs b/packages/rs-dpp/src/errors/consensus/basic/identity/duplicated_identity_public_key_basic_error.rs
index c379500239a..19a313d702c 100644
--- a/packages/rs-dpp/src/errors/consensus/basic/identity/duplicated_identity_public_key_basic_error.rs
+++ b/packages/rs-dpp/src/errors/consensus/basic/identity/duplicated_identity_public_key_basic_error.rs
@@ -9,7 +9,7 @@ use thiserror::Error;
 #[derive(
     Error, Debug, Clone, PartialEq, Eq, Encode, Decode, PlatformSerialize, PlatformDeserialize,
 )]
-#[error("Duplicated public keys ${duplicated_ids:?} found")]
+#[error("Duplicated public keys {duplicated_ids:?} found")]
 #[platform_serialize(unversioned)]
 pub struct DuplicatedIdentityPublicKeyBasicError {
     /*
diff --git a/packages/rs-dpp/src/errors/consensus/basic/identity/duplicated_identity_public_key_id_basic_error.rs b/packages/rs-dpp/src/errors/consensus/basic/identity/duplicated_identity_public_key_id_basic_error.rs
index 9cd9b9485c3..cf95281b69a 100644
--- a/packages/rs-dpp/src/errors/consensus/basic/identity/duplicated_identity_public_key_id_basic_error.rs
+++ b/packages/rs-dpp/src/errors/consensus/basic/identity/duplicated_identity_public_key_id_basic_error.rs
@@ -9,7 +9,7 @@ use thiserror::Error;
 #[derive(
     Error, Debug, Clone, PartialEq, Eq, Encode, Decode, PlatformSerialize, PlatformDeserialize,
 )]
-#[error("Duplicated public key ids ${duplicated_ids:?} found")]
+#[error("Duplicated public key ids {duplicated_ids:?} found")]
 #[platform_serialize(unversioned)]
 pub struct DuplicatedIdentityPublicKeyIdBasicError {
     /*
diff --git a/packages/rs-dpp/src/errors/consensus/basic/identity/identity_asset_lock_transaction_out_point_already_exists_error.rs b/packages/rs-dpp/src/errors/consensus/basic/identity/identity_asset_lock_transaction_out_point_already_exists_error.rs
index 70ebc47bd62..31b149e0e1d 100644
--- a/packages/rs-dpp/src/errors/consensus/basic/identity/identity_asset_lock_transaction_out_point_already_exists_error.rs
+++ b/packages/rs-dpp/src/errors/consensus/basic/identity/identity_asset_lock_transaction_out_point_already_exists_error.rs
@@ -9,7 +9,7 @@ use thiserror::Error;
 #[derive(
     Error, Debug, Clone, PartialEq, Eq, Encode, Decode, PlatformSerialize, PlatformDeserialize,
 )]
-#[error("Asset lock transaction ${transaction_id:?} output ${output_index:?} already used")]
+#[error("Asset lock transaction {transaction_id} output {output_index} already used")]
 #[platform_serialize(unversioned)]
 pub struct IdentityAssetLockTransactionOutPointAlreadyExistsError {
     /*
diff --git a/packages/rs-dpp/src/errors/consensus/basic/identity/identity_asset_lock_transaction_output_not_found_error.rs b/packages/rs-dpp/src/errors/consensus/basic/identity/identity_asset_lock_transaction_output_not_found_error.rs
index 37fafde1768..6f191742153 100644
--- a/packages/rs-dpp/src/errors/consensus/basic/identity/identity_asset_lock_transaction_output_not_found_error.rs
+++ b/packages/rs-dpp/src/errors/consensus/basic/identity/identity_asset_lock_transaction_output_not_found_error.rs
@@ -8,7 +8,7 @@ use thiserror::Error;
 #[derive(
     Error, Debug, Clone, PartialEq, Eq, Encode, Decode, PlatformSerialize, PlatformDeserialize,
 )]
-#[error("Asset Lock Transaction Output with index ${output_index} not found")]
+#[error("Asset Lock Transaction Output with index {output_index} not found")]
 #[platform_serialize(unversioned)]
 pub struct IdentityAssetLockTransactionOutputNotFoundError {
     /*
diff --git a/packages/rs-dpp/src/errors/consensus/basic/identity/invalid_asset_lock_transaction_output_return_size.rs b/packages/rs-dpp/src/errors/consensus/basic/identity/invalid_asset_lock_transaction_output_return_size.rs
index dc40037f811..d0967509242 100644
--- a/packages/rs-dpp/src/errors/consensus/basic/identity/invalid_asset_lock_transaction_output_return_size.rs
+++ b/packages/rs-dpp/src/errors/consensus/basic/identity/invalid_asset_lock_transaction_output_return_size.rs
@@ -9,7 +9,7 @@ use thiserror::Error;
     Error, Debug, Clone, PartialEq, Eq, Encode, Decode, PlatformSerialize, PlatformDeserialize,
 )]
 #[error(
-    "Asset Lock output ${output_index} has invalid public key hash. Must be 20 length bytes hash"
+    "Asset Lock output {output_index} has invalid public key hash. Must be 20 length bytes hash"
 )]
 #[platform_serialize(unversioned)]
 pub struct InvalidAssetLockTransactionOutputReturnSizeError {
diff --git a/packages/rs-dpp/src/errors/consensus/basic/identity/invalid_identity_asset_lock_transaction_error.rs b/packages/rs-dpp/src/errors/consensus/basic/identity/invalid_identity_asset_lock_transaction_error.rs
index 430de27b82f..758c9fa362b 100644
--- a/packages/rs-dpp/src/errors/consensus/basic/identity/invalid_identity_asset_lock_transaction_error.rs
+++ b/packages/rs-dpp/src/errors/consensus/basic/identity/invalid_identity_asset_lock_transaction_error.rs
@@ -7,7 +7,7 @@ use thiserror::Error;
 use bincode::{Decode, Encode};
 
 #[derive(Error, Debug, Clone, Encode, Decode, PlatformSerialize, PlatformDeserialize)]
-#[error("Invalid asset lock transaction: ${message}")]
+#[error("Invalid asset lock transaction: {message}")]
 #[platform_serialize(unversioned)]
 pub struct InvalidIdentityAssetLockTransactionError {
     /*
diff --git a/packages/rs-dpp/src/errors/consensus/basic/identity/invalid_identity_asset_lock_transaction_output_error.rs b/packages/rs-dpp/src/errors/consensus/basic/identity/invalid_identity_asset_lock_transaction_output_error.rs
index ad215b2b706..495f8d7e494 100644
--- a/packages/rs-dpp/src/errors/consensus/basic/identity/invalid_identity_asset_lock_transaction_output_error.rs
+++ b/packages/rs-dpp/src/errors/consensus/basic/identity/invalid_identity_asset_lock_transaction_output_error.rs
@@ -8,7 +8,7 @@ use thiserror::Error;
 #[derive(
     Error, Debug, Clone, PartialEq, Eq, Encode, Decode, PlatformSerialize, PlatformDeserialize,
 )]
-#[error("Asset lock output ${output_index} is not a valid standard OP_RETURN output")]
+#[error("Asset lock output {output_index} is not a valid standard OP_RETURN output")]
 #[platform_serialize(unversioned)]
 pub struct InvalidIdentityAssetLockTransactionOutputError {
     /*
diff --git a/packages/rs-dpp/src/errors/consensus/basic/identity/invalid_instant_asset_lock_proof_error.rs b/packages/rs-dpp/src/errors/consensus/basic/identity/invalid_instant_asset_lock_proof_error.rs
index 08eb6828be5..dabe336c605 100644
--- a/packages/rs-dpp/src/errors/consensus/basic/identity/invalid_instant_asset_lock_proof_error.rs
+++ b/packages/rs-dpp/src/errors/consensus/basic/identity/invalid_instant_asset_lock_proof_error.rs
@@ -8,7 +8,7 @@ use thiserror::Error;
 #[derive(
     Error, Debug, Clone, PartialEq, Eq, Encode, Decode, PlatformSerialize, PlatformDeserialize,
 )]
-#[error("Invalid instant lock proof: ${message}")]
+#[error("Invalid instant lock proof: {message}")]
 #[platform_serialize(unversioned)]
 pub struct InvalidInstantAssetLockProofError {
     /*
diff --git a/packages/rs-dpp/src/errors/consensus/state/identity/identity_already_exists_error.rs b/packages/rs-dpp/src/errors/consensus/state/identity/identity_already_exists_error.rs
index 45eab230d48..b07f91df7a2 100644
--- a/packages/rs-dpp/src/errors/consensus/state/identity/identity_already_exists_error.rs
+++ b/packages/rs-dpp/src/errors/consensus/state/identity/identity_already_exists_error.rs
@@ -9,7 +9,7 @@ use thiserror::Error;
 #[derive(
     Error, Debug, Clone, PartialEq, Eq, Encode, Decode, PlatformSerialize, PlatformDeserialize,
 )]
-#[error("Identity ${identity_id:?} already exists")]
+#[error("Identity {identity_id:?} already exists")]
 #[platform_serialize(unversioned)]
 pub struct IdentityAlreadyExistsError {
     /*
diff --git a/packages/rs-dpp/src/errors/consensus/state/identity/identity_insufficient_balance_error.rs b/packages/rs-dpp/src/errors/consensus/state/identity/identity_insufficient_balance_error.rs
index 22f61886ad0..a167fc14111 100644
--- a/packages/rs-dpp/src/errors/consensus/state/identity/identity_insufficient_balance_error.rs
+++ b/packages/rs-dpp/src/errors/consensus/state/identity/identity_insufficient_balance_error.rs
@@ -11,7 +11,7 @@ use bincode::{Decode, Encode};
 #[derive(
     Error, Debug, Clone, PartialEq, Eq, Encode, Decode, PlatformSerialize, PlatformDeserialize,
 )]
-#[error("Insufficient identity ${identity_id} balance ${balance} required ${required_balance}")]
+#[error("Insufficient identity {identity_id} balance ${balance} required ${required_balance}")]
 #[platform_serialize(unversioned)]
 pub struct IdentityInsufficientBalanceError {
     /*
diff --git a/packages/rs-dpp/src/errors/consensus/state/identity/identity_public_key_already_exists_for_unique_contract_bounds_error.rs b/packages/rs-dpp/src/errors/consensus/state/identity/identity_public_key_already_exists_for_unique_contract_bounds_error.rs
index f540be55ebe..ec206efcac6 100644
--- a/packages/rs-dpp/src/errors/consensus/state/identity/identity_public_key_already_exists_for_unique_contract_bounds_error.rs
+++ b/packages/rs-dpp/src/errors/consensus/state/identity/identity_public_key_already_exists_for_unique_contract_bounds_error.rs
@@ -10,7 +10,7 @@ use thiserror::Error;
 #[derive(
     Error, Debug, Clone, PartialEq, Eq, Encode, Decode, PlatformSerialize, PlatformDeserialize,
 )]
-#[error("Identity Public Key with id ${new_key_id} for identity ${identity_id:?} conflicts for purpose ${purpose} with key ${old_key_id} in the contract bounds of ${contract_id:?}")]
+#[error("Identity Public Key with id {new_key_id} for identity {identity_id:?} conflicts for purpose {purpose} with key {old_key_id} in the contract bounds of {contract_id:?}")]
 #[platform_serialize(unversioned)]
 pub struct IdentityPublicKeyAlreadyExistsForUniqueContractBoundsError {
     /*