Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "preload" option with "swap" value does not work as expected #76

Open
DavyJones21 opened this issue Dec 27, 2024 · 0 comments
Open

The "preload" option with "swap" value does not work as expected #76

DavyJones21 opened this issue Dec 27, 2024 · 0 comments

Comments

@DavyJones21
Copy link

Expected: <link rel="preload" href="some.css" as="style" onload="this.rel='stylesheet'">
In fact: <link rel="stylesheet" href="some.css" onload="this.rel='stylesheet'">

I think we missed updateLinkToPreload = true right here: https://github.com/danielroe/beasties/blob/main/packages/beasties/src/index.ts#L315
@DavyJones21 DavyJones21 changed the title The preload option with "swap" value does not work as expected The "preload" option with "swap" value does not work as expected Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DavyJones21