Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cose-bilkent does not respect locked nodes #50

Open
JLHwung opened this issue Jul 18, 2017 · 1 comment
Open

cose-bilkent does not respect locked nodes #50

JLHwung opened this issue Jul 18, 2017 · 1 comment

Comments

@JLHwung
Copy link
Contributor

JLHwung commented Jul 18, 2017

Correct me if I am wrong, but I search locked in the codebase and find nothing.

In cose layout, the gravitational/repulsion force takes locked into consideration, see https://github.com/cytoscape/cytoscape.js/blob/master/src/extensions/layout/cose.js#L357 and https://github.com/cytoscape/cytoscape.js/blob/master/src/extensions/layout/cose.js#L529.

However, I did not see any locked in https://github.com/cytoscape/cytoscape.js-cose-bilkent/blob/master/src/Layout/FDLayout.js#L208 and https://github.com/cytoscape/cytoscape.js-cose-bilkent/blob/master/src/Layout/FDLayout.js#L281.

I can work on a PR to respect locked nodes. Is there any algorithmic difficult on locked nodes? Thank you.

@ugurdogrusoz
Copy link
Contributor

@JLHwung feel free to work on locking specified nodes. This is where you need to disallow movement of nodes. However notice that prior to layout starting you should resolve any inconsistencies. For instance, locking a parent compound node with children unlocked will create problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants