Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire HTTP API as datasource for cvexplore #222

Closed
Tracked by #213
P-T-I opened this issue Dec 14, 2023 · 5 comments
Closed
Tracked by #213

Retire HTTP API as datasource for cvexplore #222

P-T-I opened this issue Dec 14, 2023 · 5 comments
Labels
Investigation needed question Further information is requested

Comments

@P-T-I
Copy link
Member

P-T-I commented Dec 14, 2023

Open question; is the HTTP API as a datasource still needed or can we retire this funcitonality in light of the #213 roadmap

@P-T-I P-T-I added question Further information is requested Investigation needed labels Dec 14, 2023
@baonq-me
Copy link

What do you mean by "retire"?

@P-T-I
Copy link
Member Author

P-T-I commented Dec 15, 2023

Remove... CveXplore is able to use the cvesearch query api endpoint as a datasource; but for me (looking at the new design) this is no longer a viable option as it feels like going in circles...

@baonq-me
Copy link

baonq-me commented Dec 16, 2023

Remove... CveXplore is able to use the cvesearch query api endpoint as a datasource; but for me (looking at the new design) this is no longer a viable option as it feels like going in circles...

@P-T-I What do you think about my below idea?

Based on what I have analyzed previously about three use cases:

For the first group of people who want to use CLI. I know many CLI tools use this approach. We can host a public demp instance of cve-search-api so people don't need to deploy anything except CveXplore (or they can deploy their own instance otherwise if needed).

CleanShot 2023-12-16 at 16 35 24@2x

For the second group of people who want to use every component:

CleanShot 2023-12-16 at 16 40 33@2x

For the third group of people who care about integrations rather than GUI:

CleanShot 2023-12-16 at 16 41 59@2x

Another thing to consider is that cve-search is currently having 2.1K stars, so people will likely want to contribute to that project more than a new and fewer stars project. Of course, we can split cve-search into two seperate folders, for example, cve-search-frontend and cve-search-api.

@P-T-I
Copy link
Member Author

P-T-I commented Dec 16, 2023

@baonq-me FYI there is a public instance (https://cvepremium.circl.lu) and yes, the first use case you described is exactly where I designed cvexplore for; for people who just want to download the lib and use the public instance as a data source. So I think we can agree that we'll keep that as is.

I don't believe splitting up the CveSearch rest api from the frontend source code would lead to much benefit. So only the CLI functionality would be fased out (in due time) from the CveSearch repo.

@P-T-I
Copy link
Member Author

P-T-I commented Dec 16, 2023

I believe this issue can be closed; feel free to reopen if needed!

@P-T-I P-T-I closed this as not planned Won't fix, can't repro, duplicate, stale Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Investigation needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants